Page MenuHomePhabricator
Files F15471270

D11237.id26983.diff
No OneTemporary
Actions

D11237.id26983.diff
View Options

diff --git a/src/lint/linter/ArcanistCSSLintLinter.php b/src/lint/linter/ArcanistCSSLintLinter.php
--- a/src/lint/linter/ArcanistCSSLintLinter.php
+++ b/src/lint/linter/ArcanistCSSLintLinter.php
@@ -25,14 +25,14 @@
return 'csslint';
}
- public function getMandatoryFlags() {
+ protected function getMandatoryFlags() {
return array(
'--format=lint-xml',
'--quiet',
);
}
- public function getDefaultFlags() {
+ protected function getDefaultFlags() {
return $this->getDeprecatedConfiguration('lint.csslint.options', array());
}
diff --git a/src/lint/linter/ArcanistCSharpLinter.php b/src/lint/linter/ArcanistCSharpLinter.php
--- a/src/lint/linter/ArcanistCSharpLinter.php
+++ b/src/lint/linter/ArcanistCSharpLinter.php
@@ -54,7 +54,7 @@
parent::setLinterConfigurationValue($key, $value);
}
- public function getLintCodeFromLinterConfigurationKey($code) {
+ protected function getLintCodeFromLinterConfigurationKey($code) {
return $code;
}
diff --git a/src/lint/linter/ArcanistChmodLinter.php b/src/lint/linter/ArcanistChmodLinter.php
--- a/src/lint/linter/ArcanistChmodLinter.php
+++ b/src/lint/linter/ArcanistChmodLinter.php
@@ -27,7 +27,7 @@
return 'chmod';
}
- public function shouldLintBinaryFiles() {
+ protected function shouldLintBinaryFiles() {
return true;
}
diff --git a/src/lint/linter/ArcanistFilenameLinter.php b/src/lint/linter/ArcanistFilenameLinter.php
--- a/src/lint/linter/ArcanistFilenameLinter.php
+++ b/src/lint/linter/ArcanistFilenameLinter.php
@@ -25,7 +25,7 @@
return 'filename';
}
- public function shouldLintBinaryFiles() {
+ protected function shouldLintBinaryFiles() {
return true;
}
@@ -45,11 +45,11 @@
}
}
- public function shouldLintDirectories() {
+ protected function shouldLintDirectories() {
return true;
}
- public function shouldLintSymbolicLinks() {
+ protected function shouldLintSymbolicLinks() {
return true;
}
diff --git a/src/lint/linter/ArcanistFlake8Linter.php b/src/lint/linter/ArcanistFlake8Linter.php
--- a/src/lint/linter/ArcanistFlake8Linter.php
+++ b/src/lint/linter/ArcanistFlake8Linter.php
@@ -28,7 +28,7 @@
return 'flake8';
}
- public function getDefaultFlags() {
+ protected function getDefaultFlags() {
return $this->getDeprecatedConfiguration('lint.flake8.options', array());
}
diff --git a/src/lint/linter/ArcanistHLintLinter.php b/src/lint/linter/ArcanistHLintLinter.php
--- a/src/lint/linter/ArcanistHLintLinter.php
+++ b/src/lint/linter/ArcanistHLintLinter.php
@@ -45,7 +45,7 @@
return true;
}
- public function getMandatoryFlags() {
+ protected function getMandatoryFlags() {
return array('--json');
}
diff --git a/src/lint/linter/ArcanistPEP8Linter.php b/src/lint/linter/ArcanistPEP8Linter.php
--- a/src/lint/linter/ArcanistPEP8Linter.php
+++ b/src/lint/linter/ArcanistPEP8Linter.php
@@ -27,7 +27,7 @@
return 'pep8';
}
- public function getDefaultFlags() {
+ protected function getDefaultFlags() {
return $this->getDeprecatedConfiguration('lint.pep8.options', array());
}
diff --git a/src/lint/linter/ArcanistPhpLinter.php b/src/lint/linter/ArcanistPhpLinter.php
--- a/src/lint/linter/ArcanistPhpLinter.php
+++ b/src/lint/linter/ArcanistPhpLinter.php
@@ -26,7 +26,7 @@
return 'php';
}
- public function getMandatoryFlags() {
+ protected function getMandatoryFlags() {
return array('-l');
}
diff --git a/src/lint/linter/ArcanistPhpcsLinter.php b/src/lint/linter/ArcanistPhpcsLinter.php
--- a/src/lint/linter/ArcanistPhpcsLinter.php
+++ b/src/lint/linter/ArcanistPhpcsLinter.php
@@ -37,7 +37,7 @@
return pht('Install PHPCS with `pear install PHP_CodeSniffer`.');
}
- public function getDefaultFlags() {
+ protected function getDefaultFlags() {
$options = $this->getDeprecatedConfiguration('lint.phpcs.options', array());
$standard = $this->getDeprecatedConfiguration('lint.phpcs.standard');

File Metadata

Mime Type
text/plain
Expires
Sun, Apr 6, 4:18 AM (1 d, 17 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7733927
Default Alt Text
D11237.id26983.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility