Page MenuHomePhabricator
Files F15467119

D19385.id46368.diff
No OneTemporary
Actions

D19385.id46368.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -9,7 +9,7 @@
'names' => array(
'conpherence.pkg.css' => 'e68cf1fa',
'conpherence.pkg.js' => '15191c65',
- 'core.pkg.css' => '39061f68',
+ 'core.pkg.css' => 'c66eeb30',
'core.pkg.js' => 'e1f0f7bd',
'differential.pkg.css' => '06dc617c',
'differential.pkg.js' => 'c2ca903a',
@@ -131,7 +131,7 @@
'rsrc/css/phui/object-item/phui-oi-color.css' => 'cd2b9b77',
'rsrc/css/phui/object-item/phui-oi-drag-ui.css' => '08f4ccc3',
'rsrc/css/phui/object-item/phui-oi-flush-ui.css' => '9d9685d6',
- 'rsrc/css/phui/object-item/phui-oi-list-view.css' => 'ae1404ba',
+ 'rsrc/css/phui/object-item/phui-oi-list-view.css' => '7c5c1291',
'rsrc/css/phui/object-item/phui-oi-simple-ui.css' => 'a8beebea',
'rsrc/css/phui/phui-action-list.css' => '0bcd9a45',
'rsrc/css/phui/phui-action-panel.css' => 'b4798122',
@@ -838,7 +838,7 @@
'phui-oi-color-css' => 'cd2b9b77',
'phui-oi-drag-ui-css' => '08f4ccc3',
'phui-oi-flush-ui-css' => '9d9685d6',
- 'phui-oi-list-view-css' => 'ae1404ba',
+ 'phui-oi-list-view-css' => '7c5c1291',
'phui-oi-simple-ui-css' => 'a8beebea',
'phui-pager-css' => 'edcbc226',
'phui-pinboard-view-css' => '2495140e',
diff --git a/src/applications/differential/view/DifferentialRevisionListView.php b/src/applications/differential/view/DifferentialRevisionListView.php
--- a/src/applications/differential/view/DifferentialRevisionListView.php
+++ b/src/applications/differential/view/DifferentialRevisionListView.php
@@ -229,22 +229,30 @@
$classes = array();
$classes[] = 'differential-revision-size';
+ $tip = array();
+ $tip[] = pht('%s Lines', new PhutilNumber($n));
+
if ($plus_count <= 1) {
$classes[] = 'differential-revision-small';
+ $tip[] = pht('Smaller Change');
}
if ($plus_count >= 4) {
$classes[] = 'differential-revision-large';
+ $tip[] = pht('Larger Change');
}
+ $tip = phutil_implode_html(" \xC2\xB7 ", $tip);
+
return javelin_tag(
'span',
array(
'class' => implode(' ', $classes),
'sigil' => 'has-tooltip',
'meta' => array(
- 'tip' => pht('%s Lines', new PhutilNumber($n)),
+ 'tip' => $tip,
'align' => 'E',
+ 'size' => 400,
),
),
$size);
diff --git a/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css b/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
--- a/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
+++ b/webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
@@ -697,22 +697,26 @@
.differential-revision-size .phui-icon-view {
margin: 0 1px 0 1px;
- font-size: smaller;
- color: {$blueborder};
+ font-size: 7px;
+ position: relative;
+ top: -2px;
+ color: {$lightbluetext};
}
.differential-revision-large {
- background: {$sh-redbackground};
+ background: {$sh-orangebackground};
}
+/* NOTE: These are intentionally using nonstandard colors, see T13127. */
+
.differential-revision-large .phui-icon-view {
- color: {$red};
+ color: #e5ae7e;
}
.differential-revision-small {
- background: {$sh-greenbackground};
+ background: #f2f7ff;
}
.differential-revision-small .phui-icon-view {
- color: {$green};
+ color: #6699ba;
}

File Metadata

Mime Type
text/plain
Expires
Fri, Apr 4, 12:54 PM (5 d, 34 m ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7730254
Default Alt Text
D19385.id46368.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility