Page MenuHomePhabricator
Files F15466034

D20888.diff
No OneTemporary
Actions

D20888.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -179,7 +179,7 @@
'rsrc/css/phui/phui-two-column-view.css' => '01e6991e',
'rsrc/css/phui/workboards/phui-workboard-color.css' => 'e86de308',
'rsrc/css/phui/workboards/phui-workboard.css' => '74fc9d98',
- 'rsrc/css/phui/workboards/phui-workcard.css' => '913441b6',
+ 'rsrc/css/phui/workboards/phui-workcard.css' => 'a4d43681',
'rsrc/css/phui/workboards/phui-workpanel.css' => '3ae89b20',
'rsrc/css/sprite-login.css' => '18b368a6',
'rsrc/css/sprite-tokens.css' => 'f1896dc5',
@@ -876,7 +876,7 @@
'phui-two-column-view-css' => '01e6991e',
'phui-workboard-color-css' => 'e86de308',
'phui-workboard-view-css' => '74fc9d98',
- 'phui-workcard-view-css' => '913441b6',
+ 'phui-workcard-view-css' => 'a4d43681',
'phui-workpanel-view-css' => '3ae89b20',
'phuix-action-list-view' => 'c68f183f',
'phuix-action-view' => 'aaa08f3b',
diff --git a/src/applications/maniphest/engineextension/ManiphestHovercardEngineExtension.php b/src/applications/maniphest/engineextension/ManiphestHovercardEngineExtension.php
--- a/src/applications/maniphest/engineextension/ManiphestHovercardEngineExtension.php
+++ b/src/applications/maniphest/engineextension/ManiphestHovercardEngineExtension.php
@@ -61,6 +61,17 @@
$card->setProjectHandles($project_handles);
}
+ $cover_phid = $task->getCoverImageThumbnailPHID();
+ if ($cover_phid) {
+ $cover_file = id(new PhabricatorFileQuery())
+ ->setViewer($viewer)
+ ->withPHIDs(array($cover_phid))
+ ->executeOne();
+ if ($cover_file) {
+ $card->setCoverImageFile($cover_file);
+ }
+ }
+
$item = $card->getItem();
$card = id(new PHUIObjectItemListView())
->setFlush(true)
diff --git a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
--- a/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
+++ b/src/applications/transactions/storage/PhabricatorApplicationTransaction.php
@@ -442,9 +442,13 @@
}
protected function renderPolicyName($phid, $state = 'old') {
- $policy = PhabricatorPolicy::newFromPolicyAndHandle(
- $phid,
- $this->getHandleIfExists($phid));
+ try {
+ $policy = PhabricatorPolicy::newFromPolicyAndHandle(
+ $phid,
+ $this->getHandleIfExists($phid));
+ } catch (Exception $ex) {
+ return pht('Invalid Policy <%s>', $phid);
+ }
$ref = $policy->newRef($this->getViewer());
diff --git a/webroot/rsrc/css/phui/workboards/phui-workcard.css b/webroot/rsrc/css/phui/workboards/phui-workcard.css
--- a/webroot/rsrc/css/phui/workboards/phui-workcard.css
+++ b/webroot/rsrc/css/phui/workboards/phui-workcard.css
@@ -123,10 +123,16 @@
margin-bottom: 8px;
}
+.phui-workcard .phui-oi-frame-cover {
+ background: {$lightgreybackground};
+ border-bottom: 1px solid {$thinblueborder};
+}
+
.phui-workcard .phui-oi-cover-image {
display: block;
- padding: 8px 8px 0 8px;
+ padding: 8px;
width: 263px;
+ margin: auto;
}
.phui-workcard.phui-oi.phui-workcard-upload-target {

File Metadata

Mime Type
text/plain
Expires
Fri, Apr 4, 12:57 AM (2 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7522860
Default Alt Text
D20888.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility