D8863.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D8863.diff
View Options

	diff --git a/src/applications/home/controller/PhabricatorHomeQuickCreateController.php b/src/applications/home/controller/PhabricatorHomeQuickCreateController.php
	--- a/src/applications/home/controller/PhabricatorHomeQuickCreateController.php
	+++ b/src/applications/home/controller/PhabricatorHomeQuickCreateController.php
	@@ -29,6 +29,7 @@
	),
	array(
	'title' => pht('Quick Create'),
	+ 'device' => true,
	));
	}

	diff --git a/src/applications/people/remarkup/PhabricatorRemarkupRuleMention.php b/src/applications/people/remarkup/PhabricatorRemarkupRuleMention.php
	--- a/src/applications/people/remarkup/PhabricatorRemarkupRuleMention.php
	+++ b/src/applications/people/remarkup/PhabricatorRemarkupRuleMention.php
	@@ -18,7 +18,10 @@
	// username, so we'll incorrectly pick it up, but there's little to be done
	// about that. We forbid terminal periods so that we can correctly capture
	// "@joe" instead of "@joe." in "Hey, @joe.".
	- const REGEX = '/(?<!\w)@([a-zA-Z0-9._-]*[a-zA-Z0-9_-])/';
	+ //
	+ // We disallow "@@joe" because it creates a false positive in the common
	+ // construction "l@@k", made popular by eBay.
	+ const REGEX = '/(?<!\w\|@)@([a-zA-Z0-9._-]*[a-zA-Z0-9_-])/';

	public function apply($text) {
	return preg_replace_callback(