Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15464436
D9386.id22382.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D9386.id22382.diff
View Options
diff --git a/src/applications/notification/client/PhabricatorNotificationClient.php b/src/applications/notification/client/PhabricatorNotificationClient.php
--- a/src/applications/notification/client/PhabricatorNotificationClient.php
+++ b/src/applications/notification/client/PhabricatorNotificationClient.php
@@ -2,7 +2,7 @@
final class PhabricatorNotificationClient {
- const EXPECT_VERSION = 3;
+ const EXPECT_VERSION = 4;
public static function getServerStatus() {
$uri = PhabricatorEnv::getEnvConfig('notification.server-uri');
@@ -28,7 +28,7 @@
public static function postMessage(array $data) {
$server_uri = PhabricatorEnv::getEnvConfig('notification.server-uri');
- id(new HTTPSFuture($server_uri, $data))
+ id(new HTTPSFuture($server_uri, json_encode($data)))
->setMethod('POST')
->setTimeout(1)
->resolvex();
diff --git a/support/aphlict/server/aphlict_server.js b/support/aphlict/server/aphlict_server.js
--- a/support/aphlict/server/aphlict_server.js
+++ b/support/aphlict/server/aphlict_server.js
@@ -63,7 +63,6 @@
var net = require('net');
var http = require('http');
var url = require('url');
-var querystring = require('querystring');
process.on('uncaughtException', function (err) {
debug.log("\n<<< UNCAUGHT EXCEPTION! >>>\n\n" + err);
@@ -121,7 +120,7 @@
request.on('end', function () {
++messages_in;
- var data = querystring.parse(body);
+ var data = JSON.parse(body);
debug.log('notification: ' + JSON.stringify(data));
broadcast(data);
response.end();
@@ -140,7 +139,7 @@
'messages.in': messages_in,
'messages.out': messages_out,
'log': config.log,
- 'version': 3
+ 'version': 4
};
response.write(JSON.stringify(status));
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Apr 3, 9:31 AM (3 w, 15 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7224001
Default Alt Text
D9386.id22382.diff (1 KB)
Attached To
Mode
D9386: Post data to the Aphlict server in JSON encoded form.
Attached
Detach File
Event Timeline
Log In to Comment