D14428.id34856.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D14428.id34856.diff
View Options

	diff --git a/src/applications/diffusion/conduit/DiffusionUpdateCoverageConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionUpdateCoverageConduitAPIMethod.php
	--- a/src/applications/diffusion/conduit/DiffusionUpdateCoverageConduitAPIMethod.php
	+++ b/src/applications/diffusion/conduit/DiffusionUpdateCoverageConduitAPIMethod.php
	@@ -25,6 +25,7 @@
	'branch' => 'required string',
	'commit' => 'required string',
	'coverage' => 'required map<string, string>',
	+ 'mode' => 'optional string',
	);
	}

	@@ -77,11 +78,26 @@
	$table_name = 'repository_coverage';

	$conn->openTransaction();
	- queryfx(
	- $conn,
	- 'DELETE FROM %T WHERE branchID = %d',
	- $table_name,
	- $branch->getID());
	+ $mode = $request->getValue('mode');
	+ switch ($mode) {
	+ case '':
	+ case 'set':
	+ // sets the coverage for the whole branch, deleting any previous
	+ // coverage information
	+ queryfx(
	+ $conn,
	+ 'DELETE FROM %T WHERE branchID = %d',
	+ $table_name,
	+ $branch->getID());
	+ break;
	+ case 'overwrite':
	+ // sets or overwrites coverage for the provided files on the
	+ // specified commit
	+ break;
	+ default:
	+ $conn->killTransaction();
	+ throw new Exception(pht('Invalid mode "%s".', $mode));
	+ }

	foreach (PhabricatorLiskDAO::chunkSQL($sql) as $chunk) {
	queryfx(