Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15459539
D21300.id50742.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D21300.id50742.diff
View Options
diff --git a/src/workflow/ArcanistDiffWorkflow.php b/src/workflow/ArcanistDiffWorkflow.php
--- a/src/workflow/ArcanistDiffWorkflow.php
+++ b/src/workflow/ArcanistDiffWorkflow.php
@@ -199,11 +199,6 @@
'message' => pht('%s does not update any revision.', '--only'),
),
),
- 'encoding' => array(
- 'param' => 'encoding',
- 'help' => pht(
- 'Attempt to convert non UTF-8 hunks into specified encoding.'),
- ),
'allow-untracked' => array(
'help' => pht('Skip checks for untracked files in the working copy.'),
),
@@ -956,8 +951,6 @@
}
}
- $try_encoding = nonempty($this->getArgument('encoding'), null);
-
$utf8_problems = array();
foreach ($changes as $change) {
foreach ($change->getHunks() as $hunk) {
@@ -970,17 +963,15 @@
$is_binary = ArcanistDiffUtils::isHeuristicBinaryFile($corpus);
if (!$is_binary) {
- if (!$try_encoding) {
- try {
- $try_encoding = $this->getRepositoryEncoding();
- } catch (ConduitClientException $e) {
- if ($e->getErrorCode() == 'ERR-BAD-ARCANIST-PROJECT') {
- echo phutil_console_wrap(
- pht('Lookup of encoding in arcanist project failed: %s',
- $e->getMessage())."\n");
- } else {
- throw $e;
- }
+ try {
+ $try_encoding = $this->getRepositoryEncoding();
+ } catch (ConduitClientException $e) {
+ if ($e->getErrorCode() == 'ERR-BAD-ARCANIST-PROJECT') {
+ echo phutil_console_wrap(
+ pht('Lookup of encoding in arcanist project failed: %s',
+ $e->getMessage())."\n");
+ } else {
+ throw $e;
}
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Apr 1, 1:52 PM (2 w, 16 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7363878
Default Alt Text
D21300.id50742.diff (1 KB)
Attached To
Mode
D21300: Remove "--encoding" flag from "arc diff"
Attached
Detach File
Event Timeline
Log In to Comment