D18802.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D18802.diff
View Options

	diff --git a/src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php b/src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php
	--- a/src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php
	+++ b/src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php
	@@ -162,6 +162,11 @@
	'closed. Only open revisions can be accepted.'));
	}

	+ if ($object->isDraft()) {
	+ throw new Exception(
	+ pht('You can not accept a draft revision.'));
	+ }
	+
	$config_key = 'differential.allow-self-accept';
	if (!PhabricatorEnv::getEnvConfig($config_key)) {
	if ($this->isViewerRevisionAuthor($object, $viewer)) {
	diff --git a/src/applications/differential/xaction/DifferentialRevisionResignTransaction.php b/src/applications/differential/xaction/DifferentialRevisionResignTransaction.php
	--- a/src/applications/differential/xaction/DifferentialRevisionResignTransaction.php
	+++ b/src/applications/differential/xaction/DifferentialRevisionResignTransaction.php
	@@ -64,11 +64,6 @@
	'been closed. You can only resign from open revisions.'));
	}

	- if ($object->isDraft()) {
	- throw new Exception(
	- pht('You can not resign from a draft revision.'));
	- }
	-
	$resigned = DifferentialReviewerStatus::STATUS_RESIGNED;
	if ($this->getViewerReviewerStatus($object, $viewer) == $resigned) {
	throw new Exception(