Page MenuHomePhabricator
Files F15456081

D19176.id.diff
No OneTemporary
Actions

D19176.id.diff
View Options

diff --git a/src/applications/differential/engine/DifferentialDiffExtractionEngine.php b/src/applications/differential/engine/DifferentialDiffExtractionEngine.php
--- a/src/applications/differential/engine/DifferentialDiffExtractionEngine.php
+++ b/src/applications/differential/engine/DifferentialDiffExtractionEngine.php
@@ -284,7 +284,8 @@
->setTransactionType($type_update)
->setIgnoreOnNoEffect(true)
->setNewValue($new_diff->getPHID())
- ->setMetadataValue('isCommitUpdate', true);
+ ->setMetadataValue('isCommitUpdate', true)
+ ->setMetadataValue('commitPHIDs', array($commit->getPHID()));
foreach ($more_xactions as $more_xaction) {
$xactions[] = $more_xaction;
diff --git a/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php b/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
@@ -136,4 +136,23 @@
$this->renderObject());
}
+ public function getTransactionTypeForConduit($xaction) {
+ return 'close';
+ }
+
+ public function getFieldValuesForConduit($object, $data) {
+ $commit_phid = $object->getMetadataValue('commitPHID');
+
+ if ($commit_phid) {
+ $commit_phids = array($commit_phid);
+ } else {
+ $commit_phids = array();
+ }
+
+ return array(
+ 'commitPHIDs' => $commit_phids,
+ );
+ }
+
+
}
diff --git a/src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php b/src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php
@@ -182,4 +182,18 @@
}
}
+ public function getTransactionTypeForConduit($xaction) {
+ return 'update';
+ }
+
+ public function getFieldValuesForConduit($object, $data) {
+ $commit_phids = $object->getMetadataValue('commitPHIDs', array());
+
+ return array(
+ 'old' => $object->getOldValue(),
+ 'new' => $object->getNewValue(),
+ 'commitPHIDs' => $commit_phids,
+ );
+ }
+
}

File Metadata

Mime Type
text/plain
Expires
Mon, Mar 31, 6:57 AM (4 d, 12 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7655577
Default Alt Text
D19176.id.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility