Page MenuHomePhabricator

D21693.diff
No OneTemporary

D21693.diff

diff --git a/src/applications/harbormaster/editor/HarbormasterBuildableTransactionEditor.php b/src/applications/harbormaster/editor/HarbormasterBuildableTransactionEditor.php
--- a/src/applications/harbormaster/editor/HarbormasterBuildableTransactionEditor.php
+++ b/src/applications/harbormaster/editor/HarbormasterBuildableTransactionEditor.php
@@ -14,7 +14,6 @@
public function getTransactionTypes() {
$types = parent::getTransactionTypes();
- $types[] = HarbormasterBuildableTransaction::TYPE_CREATE;
$types[] = HarbormasterBuildableTransaction::TYPE_COMMAND;
return $types;
@@ -25,7 +24,6 @@
PhabricatorApplicationTransaction $xaction) {
switch ($xaction->getTransactionType()) {
- case HarbormasterBuildableTransaction::TYPE_CREATE:
case HarbormasterBuildableTransaction::TYPE_COMMAND:
return null;
}
@@ -38,8 +36,6 @@
PhabricatorApplicationTransaction $xaction) {
switch ($xaction->getTransactionType()) {
- case HarbormasterBuildableTransaction::TYPE_CREATE:
- return true;
case HarbormasterBuildableTransaction::TYPE_COMMAND:
return $xaction->getNewValue();
}
@@ -52,7 +48,6 @@
PhabricatorApplicationTransaction $xaction) {
switch ($xaction->getTransactionType()) {
- case HarbormasterBuildableTransaction::TYPE_CREATE:
case HarbormasterBuildableTransaction::TYPE_COMMAND:
return;
}
@@ -65,7 +60,6 @@
PhabricatorApplicationTransaction $xaction) {
switch ($xaction->getTransactionType()) {
- case HarbormasterBuildableTransaction::TYPE_CREATE:
case HarbormasterBuildableTransaction::TYPE_COMMAND:
return;
}
diff --git a/src/applications/harbormaster/storage/HarbormasterBuildableTransaction.php b/src/applications/harbormaster/storage/HarbormasterBuildableTransaction.php
--- a/src/applications/harbormaster/storage/HarbormasterBuildableTransaction.php
+++ b/src/applications/harbormaster/storage/HarbormasterBuildableTransaction.php
@@ -3,7 +3,6 @@
final class HarbormasterBuildableTransaction
extends PhabricatorApplicationTransaction {
- const TYPE_CREATE = 'harbormaster:buildable:create';
const TYPE_COMMAND = 'harbormaster:buildable:command';
public function getApplicationName() {
@@ -21,10 +20,6 @@
$new = $this->getNewValue();
switch ($this->getTransactionType()) {
- case self::TYPE_CREATE:
- return pht(
- '%s created this buildable.',
- $this->renderHandleLink($author_phid));
case self::TYPE_COMMAND:
switch ($new) {
case HarbormasterBuildMessageRestartTransaction::MESSAGETYPE:
@@ -55,8 +50,6 @@
$new = $this->getNewValue();
switch ($this->getTransactionType()) {
- case self::TYPE_CREATE:
- return 'fa-plus';
case self::TYPE_COMMAND:
switch ($new) {
case HarbormasterBuildMessageRestartTransaction::MESSAGETYPE:
@@ -80,8 +73,6 @@
$new = $this->getNewValue();
switch ($this->getTransactionType()) {
- case self::TYPE_CREATE:
- return 'green';
case self::TYPE_COMMAND:
switch ($new) {
case HarbormasterBuildMessagePauseTransaction::MESSAGETYPE:

File Metadata

Mime Type
text/plain
Expires
Mon, Mar 31, 4:25 AM (3 d, 12 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7707282
Default Alt Text
D21693.diff (3 KB)

Event Timeline