Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15454101
D19438.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D19438.diff
View Options
diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -9,7 +9,7 @@
'names' => array(
'conpherence.pkg.css' => 'e68cf1fa',
'conpherence.pkg.js' => '15191c65',
- 'core.pkg.css' => 'cb8ae4dc',
+ 'core.pkg.css' => '8be474cc',
'core.pkg.js' => 'e1f0f7bd',
'differential.pkg.css' => '06dc617c',
'differential.pkg.js' => 'c2ca903a',
@@ -144,7 +144,7 @@
'rsrc/css/phui/phui-cms.css' => '504b4b23',
'rsrc/css/phui/phui-comment-form.css' => 'ac68149f',
'rsrc/css/phui/phui-comment-panel.css' => 'f50152ad',
- 'rsrc/css/phui/phui-crumbs-view.css' => '6ece3bbb',
+ 'rsrc/css/phui/phui-crumbs-view.css' => '10728aaa',
'rsrc/css/phui/phui-curtain-view.css' => '2bdaf026',
'rsrc/css/phui/phui-document-pro.css' => '8af7ea27',
'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf',
@@ -810,7 +810,7 @@
'phui-cms-css' => '504b4b23',
'phui-comment-form-css' => 'ac68149f',
'phui-comment-panel-css' => 'f50152ad',
- 'phui-crumbs-view-css' => '6ece3bbb',
+ 'phui-crumbs-view-css' => '10728aaa',
'phui-curtain-view-css' => '2bdaf026',
'phui-document-summary-view-css' => '9ca48bdf',
'phui-document-view-css' => '878c2f52',
diff --git a/src/view/phui/PHUICrumbView.php b/src/view/phui/PHUICrumbView.php
--- a/src/view/phui/PHUICrumbView.php
+++ b/src/view/phui/PHUICrumbView.php
@@ -8,6 +8,7 @@
private $isLastCrumb;
private $workflow;
private $aural;
+ private $alwaysVisible;
public function setAural($aural) {
$this->aural = $aural;
@@ -18,6 +19,22 @@
return $this->aural;
}
+ /**
+ * Make this crumb always visible, even on devices where it would normally
+ * be hidden.
+ *
+ * @param bool True to make the crumb always visible.
+ * @return this
+ */
+ public function setAlwaysVisible($always_visible) {
+ $this->alwaysVisible = $always_visible;
+ return $this;
+ }
+
+ public function getAlwaysVisible() {
+ return $this->alwaysVisible;
+ }
+
public function setWorkflow($workflow) {
$this->workflow = $workflow;
return $this;
@@ -98,6 +115,10 @@
$classes[] = 'phabricator-last-crumb';
}
+ if ($this->getAlwaysVisible()) {
+ $classes[] = 'phui-crumb-always-visible';
+ }
+
$tag = javelin_tag(
$this->href ? 'a' : 'span',
array(
diff --git a/webroot/rsrc/css/phui/phui-crumbs-view.css b/webroot/rsrc/css/phui/phui-crumbs-view.css
--- a/webroot/rsrc/css/phui/phui-crumbs-view.css
+++ b/webroot/rsrc/css/phui/phui-crumbs-view.css
@@ -55,6 +55,8 @@
}
.device-phone .phui-crumb-view.phabricator-last-crumb .phui-crumb-name,
+.device-phone .phui-crumb-view.phui-crumb-always-visible .phui-crumb-name,
+.device-phone .phui-crumb-view.phui-crumb-always-visible + .phui-crumb-divider,
.device-phone .phui-crumb-view.phui-crumb-has-icon,
.device-phone .phui-crumb-has-icon + .phui-crumb-divider {
display: inline-block;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Mar 30, 4:19 PM (3 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7727256
Default Alt Text
D19438.diff (2 KB)
Attached To
Mode
D19438: Allow navigation breadcrumbs to be marked as "always visible" so they show up on phones
Attached
Detach File
Event Timeline
Log In to Comment