Page MenuHomePhabricator
Files F15452124

D8880.diff
No OneTemporary
Actions

D8880.diff
View Options

diff --git a/src/applications/audit/query/PhabricatorCommitSearchEngine.php b/src/applications/audit/query/PhabricatorCommitSearchEngine.php
--- a/src/applications/audit/query/PhabricatorCommitSearchEngine.php
+++ b/src/applications/audit/query/PhabricatorCommitSearchEngine.php
@@ -107,8 +107,10 @@
$names = array();
if ($this->requireViewer()->isLoggedIn()) {
- $names['need_attention'] = pht('Need Attention');
+ $names['need'] = pht('Need Attention');
+ $names['problem'] = pht('Problem Commits');
}
+
$names['open'] = pht('Open Audits');
$names['all'] = pht('All Commits');
@@ -129,7 +131,7 @@
'auditStatus',
DiffusionCommitQuery::AUDIT_STATUS_OPEN);
return $query;
- case 'need_attention':
+ case 'need':
$query->setParameter('awaitingUserPHID', $viewer->getPHID());
$query->setParameter(
'auditStatus',
@@ -138,6 +140,12 @@
'auditorPHIDs',
PhabricatorAuditCommentEditor::loadAuditPHIDsForUser($viewer));
return $query;
+ case 'problem':
+ $query->setParameter('commitAuthorPHIDs', array($viewer->getPHID()));
+ $query->setParameter(
+ 'auditStatus',
+ DiffusionCommitQuery::AUDIT_STATUS_CONCERN);
+ return $query;
}
return parent::buildSavedQueryFromBuiltin($query_key);
diff --git a/src/applications/home/controller/PhabricatorHomeMainController.php b/src/applications/home/controller/PhabricatorHomeMainController.php
--- a/src/applications/home/controller/PhabricatorHomeMainController.php
+++ b/src/applications/home/controller/PhabricatorHomeMainController.php
@@ -418,6 +418,7 @@
->withAuditorPHIDs($phids)
->withAuditStatus(DiffusionCommitQuery::AUDIT_STATUS_OPEN)
->withAuditAwaitingUser($user)
+ ->needAuditRequests(true)
->needCommitData(true)
->setLimit(10);
@@ -458,6 +459,7 @@
->withAuthorPHIDs($phids)
->withAuditStatus(DiffusionCommitQuery::AUDIT_STATUS_CONCERN)
->needCommitData(true)
+ ->needAuditRequests(true)
->setLimit(10);
$commits = $query->execute();

File Metadata

Mime Type
text/plain
Expires
Sun, Mar 30, 2:03 AM (5 d, 21 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7368062
Default Alt Text
D8880.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility