Page MenuHomePhabricator

D15338.id36990.diff
No OneTemporary

D15338.id36990.diff

diff --git a/src/applications/project/controller/PhabricatorProjectBoardManageController.php b/src/applications/project/controller/PhabricatorProjectBoardManageController.php
--- a/src/applications/project/controller/PhabricatorProjectBoardManageController.php
+++ b/src/applications/project/controller/PhabricatorProjectBoardManageController.php
@@ -152,6 +152,11 @@
foreach ($columns as $column) {
$column_id = $column->getID();
+ $proxy = $column->getProxy();
+ if ($proxy && !$proxy->isMilestone()) {
+ continue;
+ }
+
$detail_uri = "/project/board/{$board_id}/column/{$column_id}/";
$item = id(new PHUIObjectItemView())
diff --git a/src/applications/project/controller/PhabricatorProjectColumnEditController.php b/src/applications/project/controller/PhabricatorProjectColumnEditController.php
--- a/src/applications/project/controller/PhabricatorProjectColumnEditController.php
+++ b/src/applications/project/controller/PhabricatorProjectColumnEditController.php
@@ -81,14 +81,15 @@
$xactions = array();
+ $type_name = PhabricatorProjectColumnTransaction::TYPE_NAME;
+ $type_limit = PhabricatorProjectColumnTransaction::TYPE_LIMIT;
+
if (!$column->getProxy()) {
- $type_name = PhabricatorProjectColumnTransaction::TYPE_NAME;
$xactions[] = id(new PhabricatorProjectColumnTransaction())
->setTransactionType($type_name)
->setNewValue($v_name);
}
- $type_limit = PhabricatorProjectColumnTransaction::TYPE_LIMIT;
$xactions[] = id(new PhabricatorProjectColumnTransaction())
->setTransactionType($type_limit)
->setNewValue($v_limit);
@@ -97,6 +98,7 @@
$editor = id(new PhabricatorProjectColumnTransactionEditor())
->setActor($viewer)
->setContinueOnNoEffect(true)
+ ->setContinueOnMissingFields(true)
->setContentSourceFromRequest($request)
->applyTransactions($column, $xactions);
return id(new AphrontRedirectResponse())->setURI($view_uri);

File Metadata

Mime Type
text/plain
Expires
Sat, Mar 29, 8:27 PM (2 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7682642
Default Alt Text
D15338.id36990.diff (2 KB)

Event Timeline