Page MenuHomePhabricator

D11368.id.diff
No OneTemporary

D11368.id.diff

diff --git a/src/applications/countdown/view/PhabricatorCountdownView.php b/src/applications/countdown/view/PhabricatorCountdownView.php
--- a/src/applications/countdown/view/PhabricatorCountdownView.php
+++ b/src/applications/countdown/view/PhabricatorCountdownView.php
@@ -17,7 +17,7 @@
}
- public function getTagContent() {
+ protected function getTagContent() {
$countdown = $this->countdown;
require_celerity_resource('phabricator-countdown-css');
diff --git a/src/applications/diviner/view/DivinerBookItemView.php b/src/applications/diviner/view/DivinerBookItemView.php
--- a/src/applications/diviner/view/DivinerBookItemView.php
+++ b/src/applications/diviner/view/DivinerBookItemView.php
@@ -27,18 +27,18 @@
return $this;
}
- public function getTagName() {
+ protected function getTagName() {
return 'a';
}
- public function getTagAttributes() {
+ protected function getTagAttributes() {
return array(
'class' => 'diviner-book-item',
'href' => $this->href,
);
}
- public function getTagContent() {
+ protected function getTagContent() {
require_celerity_resource('diviner-shared-css');
$title = phutil_tag(
diff --git a/src/applications/diviner/view/DivinerParameterTableView.php b/src/applications/diviner/view/DivinerParameterTableView.php
--- a/src/applications/diviner/view/DivinerParameterTableView.php
+++ b/src/applications/diviner/view/DivinerParameterTableView.php
@@ -15,17 +15,17 @@
return $this;
}
- public function getTagName() {
+ protected function getTagName() {
return 'div';
}
- public function getTagAttributes() {
+ protected function getTagAttributes() {
return array(
'class' => 'diviner-table-view',
);
}
- public function getTagContent() {
+ protected function getTagContent() {
require_celerity_resource('diviner-shared-css');
$rows = array();
diff --git a/src/applications/diviner/view/DivinerReturnTableView.php b/src/applications/diviner/view/DivinerReturnTableView.php
--- a/src/applications/diviner/view/DivinerReturnTableView.php
+++ b/src/applications/diviner/view/DivinerReturnTableView.php
@@ -15,17 +15,17 @@
return $this;
}
- public function getTagName() {
+ protected function getTagName() {
return 'div';
}
- public function getTagAttributes() {
+ protected function getTagAttributes() {
return array(
'class' => 'diviner-table-view',
);
}
- public function getTagContent() {
+ protected function getTagContent() {
require_celerity_resource('diviner-shared-css');
$return = $this->return;
diff --git a/src/applications/diviner/view/DivinerSectionView.php b/src/applications/diviner/view/DivinerSectionView.php
--- a/src/applications/diviner/view/DivinerSectionView.php
+++ b/src/applications/diviner/view/DivinerSectionView.php
@@ -15,17 +15,17 @@
return $this;
}
- public function getTagName() {
+ protected function getTagName() {
return 'div';
}
- public function getTagAttributes() {
+ protected function getTagAttributes() {
return array(
'class' => 'diviner-document-section',
);
}
- public function getTagContent() {
+ protected function getTagContent() {
require_celerity_resource('diviner-shared-css');
$header = id(new PHUIHeaderView())
diff --git a/src/view/form/PHUIPagedFormView.php b/src/view/form/PHUIPagedFormView.php
--- a/src/view/form/PHUIPagedFormView.php
+++ b/src/view/form/PHUIPagedFormView.php
@@ -220,7 +220,7 @@
return $this->cancelURI;
}
- public function getTagContent() {
+ protected function getTagContent() {
$form = id(new AphrontFormView())
->setUser($this->getUser());
diff --git a/src/view/phui/PHUIBoxView.php b/src/view/phui/PHUIBoxView.php
--- a/src/view/phui/PHUIBoxView.php
+++ b/src/view/phui/PHUIBoxView.php
@@ -37,11 +37,11 @@
return array('class' => $outer_classes);
}
- public function getTagName() {
+ protected function getTagName() {
return 'div';
}
- public function getTagContent() {
+ protected function getTagContent() {
return $this->renderChildren();
}
}
diff --git a/src/view/phui/PHUIButtonBarView.php b/src/view/phui/PHUIButtonBarView.php
--- a/src/view/phui/PHUIButtonBarView.php
+++ b/src/view/phui/PHUIButtonBarView.php
@@ -13,11 +13,11 @@
return array('class' => 'phui-button-bar');
}
- public function getTagName() {
+ protected function getTagName() {
return 'div';
}
- public function getTagContent() {
+ protected function getTagContent() {
require_celerity_resource('phui-button-css');
$i = 1;
diff --git a/src/view/phui/PHUIButtonView.php b/src/view/phui/PHUIButtonView.php
--- a/src/view/phui/PHUIButtonView.php
+++ b/src/view/phui/PHUIButtonView.php
@@ -82,7 +82,7 @@
return $this;
}
- public function getTagName() {
+ protected function getTagName() {
return $this->tag;
}
diff --git a/src/view/phui/PHUIDocumentView.php b/src/view/phui/PHUIDocumentView.php
--- a/src/view/phui/PHUIDocumentView.php
+++ b/src/view/phui/PHUIDocumentView.php
@@ -57,7 +57,7 @@
return $this;
}
- public function getTagAttributes() {
+ protected function getTagAttributes() {
$classes = array();
if ($this->offset) {
@@ -69,7 +69,7 @@
);
}
- public function getTagContent() {
+ protected function getTagContent() {
require_celerity_resource('phui-document-view-css');
if ($this->fontKit) {
require_celerity_resource('phui-fontkit-css');
diff --git a/src/view/phui/PHUIIconView.php b/src/view/phui/PHUIIconView.php
--- a/src/view/phui/PHUIIconView.php
+++ b/src/view/phui/PHUIIconView.php
@@ -56,7 +56,7 @@
return $this;
}
- public function getTagName() {
+ protected function getTagName() {
$tag = 'span';
if ($this->href) {
$tag = 'a';
@@ -64,7 +64,7 @@
return $tag;
}
- public function getTagAttributes() {
+ protected function getTagAttributes() {
require_celerity_resource('phui-icon-view-css');
$style = null;
diff --git a/src/view/phui/PHUIImageMaskView.php b/src/view/phui/PHUIImageMaskView.php
--- a/src/view/phui/PHUIImageMaskView.php
+++ b/src/view/phui/PHUIImageMaskView.php
@@ -41,11 +41,11 @@
return $this;
}
- public function getTagName() {
+ protected function getTagName() {
return 'div';
}
- public function getTagAttributes() {
+ protected function getTagAttributes() {
require_celerity_resource('phui-image-mask-css');
$classes = array();
@@ -62,7 +62,7 @@
}
- public function getTagContent() {
+ protected function getTagContent() {
/* Center it in the middle of the selected area */
$center_x = round($this->centerX + ($this->maskW / 2));
diff --git a/src/view/phui/PHUIListView.php b/src/view/phui/PHUIListView.php
--- a/src/view/phui/PHUIListView.php
+++ b/src/view/phui/PHUIListView.php
@@ -166,7 +166,7 @@
}
}
- public function getTagName() {
+ protected function getTagName() {
return 'ul';
}
diff --git a/src/view/phui/PHUIObjectItemView.php b/src/view/phui/PHUIObjectItemView.php
--- a/src/view/phui/PHUIObjectItemView.php
+++ b/src/view/phui/PHUIObjectItemView.php
@@ -307,7 +307,7 @@
);
}
- public function getTagContent() {
+ protected function getTagContent() {
$content_classes = array();
$content_classes[] = 'phui-object-item-content';
diff --git a/src/view/phui/PHUIRemarkupPreviewPanel.php b/src/view/phui/PHUIRemarkupPreviewPanel.php
--- a/src/view/phui/PHUIRemarkupPreviewPanel.php
+++ b/src/view/phui/PHUIRemarkupPreviewPanel.php
@@ -50,11 +50,11 @@
return $this;
}
- public function getTagName() {
+ protected function getTagName() {
return 'div';
}
- public function getTagAttributes() {
+ protected function getTagAttributes() {
$classes = array();
$classes[] = 'phui-remarkup-preview';
diff --git a/src/view/phui/PHUIStatusListView.php b/src/view/phui/PHUIStatusListView.php
--- a/src/view/phui/PHUIStatusListView.php
+++ b/src/view/phui/PHUIStatusListView.php
@@ -13,7 +13,7 @@
return false;
}
- public function getTagName() {
+ protected function getTagName() {
return 'table';
}
diff --git a/src/view/phui/PHUITagView.php b/src/view/phui/PHUITagView.php
--- a/src/view/phui/PHUITagView.php
+++ b/src/view/phui/PHUITagView.php
@@ -142,7 +142,7 @@
return $attributes + array('class' => $classes);
}
- public function getTagContent() {
+ protected function getTagContent() {
if (!$this->type) {
throw new Exception(pht('You must call setType() before render()!'));
}
diff --git a/src/view/phui/PHUITextView.php b/src/view/phui/PHUITextView.php
--- a/src/view/phui/PHUITextView.php
+++ b/src/view/phui/PHUITextView.php
@@ -9,11 +9,11 @@
return $this;
}
- public function getTagName() {
+ protected function getTagName() {
return 'span';
}
- public function getTagAttributes() {
+ protected function getTagAttributes() {
require_celerity_resource('phui-text-css');
return array();
}
diff --git a/src/view/phui/PHUIWorkboardView.php b/src/view/phui/PHUIWorkboardView.php
--- a/src/view/phui/PHUIWorkboardView.php
+++ b/src/view/phui/PHUIWorkboardView.php
@@ -27,13 +27,13 @@
return $this;
}
- public function getTagAttributes() {
+ protected function getTagAttributes() {
return array(
'class' => 'phui-workboard-view',
);
}
- public function getTagContent() {
+ protected function getTagContent() {
require_celerity_resource('phui-workboard-view-css');
$action_list = null;
diff --git a/src/view/phui/PHUIWorkpanelView.php b/src/view/phui/PHUIWorkpanelView.php
--- a/src/view/phui/PHUIWorkpanelView.php
+++ b/src/view/phui/PHUIWorkpanelView.php
@@ -55,13 +55,13 @@
return $this;
}
- public function getTagAttributes() {
+ protected function getTagAttributes() {
return array(
'class' => 'phui-workpanel-view',
);
}
- public function getTagContent() {
+ protected function getTagContent() {
require_celerity_resource('phui-workpanel-view-css');
$classes = array();
diff --git a/src/view/phui/calendar/PHUICalendarListView.php b/src/view/phui/calendar/PHUICalendarListView.php
--- a/src/view/phui/calendar/PHUICalendarListView.php
+++ b/src/view/phui/calendar/PHUICalendarListView.php
@@ -15,11 +15,11 @@
return $this;
}
- public function getTagName() {
+ protected function getTagName() {
return 'div';
}
- public function getTagAttributes() {
+ protected function getTagAttributes() {
require_celerity_resource('phui-calendar-css');
require_celerity_resource('phui-calendar-list-css');
return array('class' => 'phui-calendar-day-list');
diff --git a/src/view/phui/calendar/PHUICalendarWidgetView.php b/src/view/phui/calendar/PHUICalendarWidgetView.php
--- a/src/view/phui/calendar/PHUICalendarWidgetView.php
+++ b/src/view/phui/calendar/PHUICalendarWidgetView.php
@@ -15,11 +15,11 @@
return $this;
}
- public function getTagName() {
+ protected function getTagName() {
return 'div';
}
- public function getTagAttributes() {
+ protected function getTagAttributes() {
require_celerity_resource('phui-calendar-list-css');
return array('class' => 'phui-calendar-list-container');
}

File Metadata

Mime Type
text/plain
Expires
Sat, Mar 29, 5:22 AM (1 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7224219
Default Alt Text
D11368.id.diff (11 KB)

Event Timeline