Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15447865
D9015.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D9015.id.diff
View Options
diff --git a/src/applications/dashboard/controller/PhabricatorDashboardListController.php b/src/applications/dashboard/controller/PhabricatorDashboardListController.php
--- a/src/applications/dashboard/controller/PhabricatorDashboardListController.php
+++ b/src/applications/dashboard/controller/PhabricatorDashboardListController.php
@@ -1,10 +1,10 @@
<?php
final class PhabricatorDashboardListController
- extends PhabricatorDashboardController
- implements PhabricatorApplicationSearchResultsControllerInterface {
+ extends PhabricatorDashboardController {
private $queryKey;
+
public function willProcessRequest(array $data) {
$this->queryKey = idx($data, 'queryKey');
}
@@ -48,26 +48,4 @@
return $crumbs;
}
- public function renderResultsList(
- array $dashboards,
- PhabricatorSavedQuery $query) {
- $viewer = $this->getRequest()->getUser();
-
- $list = new PHUIObjectItemListView();
- $list->setUser($viewer);
- foreach ($dashboards as $dashboard) {
- $id = $dashboard->getID();
-
- $item = id(new PHUIObjectItemView())
- ->setObjectName(pht('Dashboard %d', $id))
- ->setHeader($dashboard->getName())
- ->setHref($this->getApplicationURI("view/{$id}/"))
- ->setObject($dashboard);
-
- $list->addItem($item);
- }
-
- return $list;
- }
-
}
diff --git a/src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php b/src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php
--- a/src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php
+++ b/src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php
@@ -3,6 +3,10 @@
final class PhabricatorDashboardSearchEngine
extends PhabricatorApplicationSearchEngine {
+ public function getApplicationClassName() {
+ return 'PhabricatorApplicationDashboard';
+ }
+
public function buildSavedQueryFromRequest(AphrontRequest $request) {
$saved = new PhabricatorSavedQuery();
@@ -46,4 +50,29 @@
return parent::buildSavedQueryFromBuiltin($query_key);
}
+
+ protected function renderResultList(
+ array $dashboards,
+ PhabricatorSavedQuery $query,
+ array $handles) {
+
+ $viewer = $this->requireViewer();
+
+ $list = new PHUIObjectItemListView();
+ $list->setUser($viewer);
+ foreach ($dashboards as $dashboard) {
+ $id = $dashboard->getID();
+
+ $item = id(new PHUIObjectItemView())
+ ->setObjectName(pht('Dashboard %d', $id))
+ ->setHeader($dashboard->getName())
+ ->setHref($this->getApplicationURI("view/{$id}/"))
+ ->setObject($dashboard);
+
+ $list->addItem($item);
+ }
+
+ return $list;
+ }
+
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Mar 29, 2:00 AM (1 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7704521
Default Alt Text
D9015.id.diff (2 KB)
Attached To
Mode
D9015: Move dashboard list rendering to ApplicationSearch
Attached
Detach File
Event Timeline
Log In to Comment