Page MenuHomePhabricator
Files F15446456

D21582.id.diff
No OneTemporary
Actions

D21582.id.diff
View Options

diff --git a/src/applications/diffusion/worker/DiffusionUpdateObjectAfterCommitWorker.php b/src/applications/diffusion/worker/DiffusionUpdateObjectAfterCommitWorker.php
--- a/src/applications/diffusion/worker/DiffusionUpdateObjectAfterCommitWorker.php
+++ b/src/applications/diffusion/worker/DiffusionUpdateObjectAfterCommitWorker.php
@@ -148,17 +148,39 @@
PhabricatorRepositoryCommit $commit,
DifferentialRevision $revision) {
+ $acting_phid = $this->getActingPHID($commit);
+ $acting_user = $this->loadActingUser($acting_phid);
+
+ // See T13625. The "Acting User" is the author of the commit based on the
+ // author string, or the Diffusion application PHID if we could not
+ // identify an author.
+
+ // This user may not be able to view the commit or the revision, and may
+ // also be unable to make API calls. Here, we execute queries and apply
+ // transactions as the omnipotent user.
+
+ // It would probably be better to use the acting user everywhere here, and
+ // exit gracefully if they can't see the revision (this is how the flow
+ // on tasks works). However, without a positive indicator in the UI
+ // explaining "no revision was updated because the author of this commit
+ // can't see anything", this might be fairly confusing, and break workflows
+ // which have worked historically.
+
+ // This isn't, per se, a policy violation (you can't get access to anything
+ // you don't already have access to by making commits that reference
+ // revisions, even if you can't see the commits or revisions), so just
+ // leave it for now.
+
+ $viewer = $this->getViewer();
+
// Reload the revision to get the active diff, which is currently required
// by "updateRevisionWithCommit()".
$revision = id(new DifferentialRevisionQuery())
- ->setViewer($this->getViewer())
+ ->setViewer($viewer)
->withIDs(array($revision->getID()))
->needActiveDiffs(true)
->executeOne();
- $acting_phid = $this->getActingPHID($commit);
- $acting_user = $this->loadActingUser($acting_phid);
-
$xactions = array();
$xactions[] = $this->newEdgeTransaction(
@@ -177,7 +199,7 @@
->setMetadataValue('commitPHID', $commit->getPHID());
$extraction_engine = id(new DifferentialDiffExtractionEngine())
- ->setViewer($acting_user)
+ ->setViewer($viewer)
->setAuthorPHID($acting_phid);
$content_source = $this->newContentSource();

File Metadata

Mime Type
text/plain
Expires
Fri, Mar 28, 7:09 PM (1 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7724622
Default Alt Text
D21582.id.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility