Page MenuHomePhabricator

D14348.diff
No OneTemporary

D14348.diff

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
*/
return array(
'names' => array(
- 'core.pkg.css' => 'c65b251d',
+ 'core.pkg.css' => 'd80f5c3e',
'core.pkg.js' => '47dc9ebb',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '2de124c9',
@@ -25,7 +25,7 @@
'rsrc/css/aphront/notification.css' => '9c279160',
'rsrc/css/aphront/panel-view.css' => '8427b78d',
'rsrc/css/aphront/phabricator-nav-view.css' => 'a24cb589',
- 'rsrc/css/aphront/table-view.css' => '63985f5b',
+ 'rsrc/css/aphront/table-view.css' => '61543e7a',
'rsrc/css/aphront/tokenizer.css' => '04875312',
'rsrc/css/aphront/tooltip.css' => '7672b60f',
'rsrc/css/aphront/typeahead-browse.css' => 'd8581d2c',
@@ -493,7 +493,7 @@
'aphront-list-filter-view-css' => '5d6f0526',
'aphront-multi-column-view-css' => 'fd18389d',
'aphront-panel-view-css' => '8427b78d',
- 'aphront-table-view-css' => '63985f5b',
+ 'aphront-table-view-css' => '61543e7a',
'aphront-tokenizer-control-css' => '04875312',
'aphront-tooltip-css' => '7672b60f',
'aphront-typeahead-control-css' => '0e403212',
diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php
--- a/src/applications/differential/controller/DifferentialRevisionViewController.php
+++ b/src/applications/differential/controller/DifferentialRevisionViewController.php
@@ -1051,12 +1051,6 @@
array(
DrydockLandRepositoryOperation::OPCONST,
))
- ->withOperationStates(
- array(
- DrydockRepositoryOperation::STATE_WAIT,
- DrydockRepositoryOperation::STATE_WORK,
- DrydockRepositoryOperation::STATE_FAIL,
- ))
->execute();
if (!$operations) {
return null;
@@ -1073,6 +1067,12 @@
}
}
+ // If we found a completed operation, don't render anything. We don't want
+ // to show an older error after the thing worked properly.
+ if ($operation->isDone()) {
+ return null;
+ }
+
$box_view = id(new PHUIObjectBoxView())
->setHeaderText(pht('Active Operations'));
diff --git a/src/applications/drydock/view/DrydockRepositoryOperationStatusView.php b/src/applications/drydock/view/DrydockRepositoryOperationStatusView.php
--- a/src/applications/drydock/view/DrydockRepositoryOperationStatusView.php
+++ b/src/applications/drydock/view/DrydockRepositoryOperationStatusView.php
@@ -115,7 +115,7 @@
->setColumnClasses(
array(
'header',
- 'wide',
+ 'wide prewrap',
));
return $table;
diff --git a/webroot/rsrc/css/aphront/table-view.css b/webroot/rsrc/css/aphront/table-view.css
--- a/webroot/rsrc/css/aphront/table-view.css
+++ b/webroot/rsrc/css/aphront/table-view.css
@@ -61,6 +61,7 @@
text-align: right;
color: {$bluetext};
font-weight: bold;
+ vertical-align: top;
}
.aphront-table-view td {

File Metadata

Mime Type
text/plain
Expires
Fri, Mar 28, 4:13 PM (1 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7705234
Default Alt Text
D14348.diff (3 KB)

Event Timeline