Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15445753
D7907.id17898.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D7907.id17898.diff
View Options
Index: resources/celerity/map.php
===================================================================
--- resources/celerity/map.php
+++ resources/celerity/map.php
@@ -7,7 +7,7 @@
return array(
'names' =>
array(
- 'core.pkg.css' => '979bfb39',
+ 'core.pkg.css' => '5ebae357',
'core.pkg.js' => 'c907bd96',
'darkconsole.pkg.js' => 'ca8671ce',
'differential.pkg.css' => '827749c1',
@@ -132,7 +132,7 @@
'rsrc/css/phui/phui-feed-story.css' => '3a59c2cf',
'rsrc/css/phui/phui-form-view.css' => '3179980c',
'rsrc/css/phui/phui-form.css' => 'b78ec020',
- 'rsrc/css/phui/phui-header-view.css' => '875d0260',
+ 'rsrc/css/phui/phui-header-view.css' => '1a93f1d9',
'rsrc/css/phui/phui-icon.css' => '29e83226',
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
'rsrc/css/phui/phui-list.css' => '2edb76cf',
@@ -736,7 +736,7 @@
'phui-feed-story-css' => '3a59c2cf',
'phui-form-css' => 'b78ec020',
'phui-form-view-css' => '3179980c',
- 'phui-header-view-css' => '875d0260',
+ 'phui-header-view-css' => '1a93f1d9',
'phui-icon-view-css' => '29e83226',
'phui-info-panel-css' => '27ea50a1',
'phui-list-view-css' => '2edb76cf',
Index: src/applications/settings/panel/PhabricatorSettingsPanelEmailAddresses.php
===================================================================
--- src/applications/settings/panel/PhabricatorSettingsPanelEmailAddresses.php
+++ src/applications/settings/panel/PhabricatorSettingsPanelEmailAddresses.php
@@ -130,21 +130,25 @@
$editable,
));
- $view = new AphrontPanelView();
+ $view = new PHUIObjectBoxView();
+ $header = new PHUIHeaderView();
+ $header->setHeader(pht('Email Addresses'));
+
if ($editable) {
- $view->addButton(
- javelin_tag(
- 'a',
- array(
- 'href' => $uri->alter('new', 'true'),
- 'class' => 'green button',
- 'sigil' => 'workflow',
- ),
- pht('Add New Address')));
+ $icon = id(new PHUIIconView())
+ ->setSpriteSheet(PHUIIconView::SPRITE_ICONS)
+ ->setSpriteIcon('new');
+
+ $button = new PHUIButtonView();
+ $button->setText(pht('Add New Address'));
+ $button->setTag('a');
+ $button->setHref($uri->alter('new', 'true'));
+ $button->setIcon($icon);
+ $button->setSigil('workflow');
+ $header->addActionLink($button);
}
- $view->setHeader(pht('Email Addresses'));
+ $view->setHeader($header);
$view->appendChild($table);
- $view->setNoBackground();
return $view;
}
Index: src/view/phui/PHUIButtonView.php
===================================================================
--- src/view/phui/PHUIButtonView.php
+++ src/view/phui/PHUIButtonView.php
@@ -19,6 +19,7 @@
private $dropdown;
private $icon;
private $href = null;
+ private $sigil = null;
public function setText($text) {
$this->text = $text;
@@ -60,6 +61,11 @@
return $this;
}
+ public function setSigil($sigil) {
+ $this->sigil = $sigil;
+ return $this;
+ }
+
public function getTagName() {
return $this->tag;
}
@@ -88,7 +94,8 @@
}
return array('class' => $classes,
- 'href' => $this->href);
+ 'href' => $this->href,
+ 'sigil' => $this->sigil);
}
protected function getTagContent() {
Index: webroot/rsrc/css/phui/phui-header-view.css
===================================================================
--- webroot/rsrc/css/phui/phui-header-view.css
+++ webroot/rsrc/css/phui/phui-header-view.css
@@ -44,7 +44,8 @@
position: relative;
}
-.phui-header-view a {
+.phui-header-view a,
+.phui-header-view a.simple {
color: {$darkbluetext};
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Mar 28, 3:49 PM (1 w, 7 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7725514
Default Alt Text
D7907.id17898.diff (3 KB)
Attached To
Mode
D7907: Update Email Address setting page
Attached
Detach File
Event Timeline
Log In to Comment