Page MenuHomePhabricator
Files F15445144

D9317.id.diff
No OneTemporary
Actions

D9317.id.diff
View Options

diff --git a/src/lint/linter/ArcanistBaseXHPASTLinter.php b/src/lint/linter/ArcanistBaseXHPASTLinter.php
--- a/src/lint/linter/ArcanistBaseXHPASTLinter.php
+++ b/src/lint/linter/ArcanistBaseXHPASTLinter.php
@@ -9,6 +9,19 @@
private $trees = array();
private $exceptions = array();
+ final public function getCacheVersion() {
+ $parts = array();
+
+ $parts[] = $this->getVersion();
+
+ $path = xhpast_get_binary_path();
+ if (Filesystem::pathExists($path)) {
+ $parts[] = md5_file($path);
+ }
+
+ return implode('-', $parts);
+ }
+
final protected function raiseLintAtToken(
XHPASTToken $token,
$code,
diff --git a/src/lint/linter/ArcanistPhutilXHPASTLinter.php b/src/lint/linter/ArcanistPhutilXHPASTLinter.php
--- a/src/lint/linter/ArcanistPhutilXHPASTLinter.php
+++ b/src/lint/linter/ArcanistPhutilXHPASTLinter.php
@@ -60,13 +60,9 @@
return 'phutil-xhpast';
}
- public function getCacheVersion() {
- $version = '2';
- $path = xhpast_get_binary_path();
- if (Filesystem::pathExists($path)) {
- $version .= '-'.md5_file($path);
- }
- return $version;
+ public function getVersion() {
+ // The version number should be incremented whenever a new rule is added.
+ return '2';
}
public function getLinterConfigurationOptions() {
diff --git a/src/lint/linter/ArcanistXHPASTLinter.php b/src/lint/linter/ArcanistXHPASTLinter.php
--- a/src/lint/linter/ArcanistXHPASTLinter.php
+++ b/src/lint/linter/ArcanistXHPASTLinter.php
@@ -186,13 +186,9 @@
return parent::setLinterConfigurationValue($key, $value);
}
- public function getCacheVersion() {
- $version = '5';
- $path = xhpast_get_binary_path();
- if (Filesystem::pathExists($path)) {
- $version .= '-'.md5_file($path);
- }
- return $version;
+ public function getVersion() {
+ // The version number should be incremented whenever a new rule is added.
+ return '5';
}
protected function resolveFuture($path, Future $future) {

File Metadata

Mime Type
text/plain
Expires
Fri, Mar 28, 12:34 PM (1 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7711422
Default Alt Text
D9317.id.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility