Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15444195
D17325.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
678 B
Referenced Files
None
Subscribers
None
D17325.diff
View Options
diff --git a/src/workflow/ArcanistWorkflow.php b/src/workflow/ArcanistWorkflow.php
--- a/src/workflow/ArcanistWorkflow.php
+++ b/src/workflow/ArcanistWorkflow.php
@@ -1196,6 +1196,14 @@
$future = $conduit->callMethod('differential.querydiffs', $params);
$diff = head($future->resolve());
+ if ($diff == null) {
+ throw new Exception(
+ phutil_console_wrap(
+ pht("The diff or revision you specified is either invalid or you ".
+ "don't have permission to view it."))
+ );
+ }
+
$changes = array();
foreach ($diff['changes'] as $changedict) {
$changes[] = ArcanistDiffChange::newFromDictionary($changedict);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Mar 28, 8:24 AM (2 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7578048
Default Alt Text
D17325.diff (678 B)
Attached To
Mode
D17325: Provide a better error message when an invalid ID is given to arc patch
Attached
Detach File
Event Timeline
Log In to Comment