Page MenuHomePhabricator
Files F15442582

D17232.id.diff
No OneTemporary
Actions

D17232.id.diff
View Options

diff --git a/src/lint/linter/__tests__/jshint/jshint.lint-test b/src/lint/linter/__tests__/jshint/jshint.lint-test
--- a/src/lint/linter/__tests__/jshint/jshint.lint-test
+++ b/src/lint/linter/__tests__/jshint/jshint.lint-test
@@ -9,4 +9,4 @@
~~~~~~~~~~
warning:3:8
error:7:1
-error:9:
+error:9:1
diff --git a/src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php b/src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php
--- a/src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php
+++ b/src/lint/linter/xhpast/ArcanistXHPASTLinterRule.php
@@ -213,6 +213,8 @@
$calls = $root->selectDescendantsOfType('n_FUNCTION_CALL');
$nodes = array();
+ $function_names = array_map('strtolower', $function_names);
+
foreach ($calls as $call) {
$node = $call->getChildByIndex(0);
$name = strtolower($node->getConcreteString());
diff --git a/src/lint/linter/xhpast/rules/ArcanistDeprecationXHPASTLinterRule.php b/src/lint/linter/xhpast/rules/ArcanistDeprecationXHPASTLinterRule.php
--- a/src/lint/linter/xhpast/rules/ArcanistDeprecationXHPASTLinterRule.php
+++ b/src/lint/linter/xhpast/rules/ArcanistDeprecationXHPASTLinterRule.php
@@ -37,15 +37,17 @@
}
public function process(XHPASTNode $root) {
- $map = $this->deprecatedFunctions;
- $function_calls = $this->getFunctionCalls($root, array_keys($map));
+ $map = new CaseInsensitiveArray($this->deprecatedFunctions);
+
+ $function_calls = $this->getFunctionCalls(
+ $root,
+ array_keys($this->deprecatedFunctions));
foreach ($function_calls as $call) {
$name = $call
->getChildByIndex(0)
->getConcreteString();
- $name = strtolower($name);
if (empty($map[$name])) {
continue;
}
diff --git a/src/lint/linter/xhpast/rules/__tests__/deprecation/deprecated-function.lint-test b/src/lint/linter/xhpast/rules/__tests__/deprecation/deprecated-function.lint-test
--- a/src/lint/linter/xhpast/rules/__tests__/deprecation/deprecated-function.lint-test
+++ b/src/lint/linter/xhpast/rules/__tests__/deprecation/deprecated-function.lint-test
@@ -1,15 +1,17 @@
<?php
-deprecated_function();
+deprecatedfunction();
modern_function();
+DeprecatedFunction();
~~~~~~~~~~
warning:3:1
+warning:5:1
~~~~~~~~~~
~~~~~~~~~~
{
"config": {
"xhpast.deprecated.functions": {
- "deprecated_function": "This function is deprecated."
+ "DeprecatedFunction": "This function is deprecated."
}
}
}
diff --git a/src/lint/linter/xhpast/rules/__tests__/deprecation/deprecated-static-method.lint-test b/src/lint/linter/xhpast/rules/__tests__/deprecation/deprecated-static-method.lint-test
new file mode 100644
--- /dev/null
+++ b/src/lint/linter/xhpast/rules/__tests__/deprecation/deprecated-static-method.lint-test
@@ -0,0 +1,17 @@
+<?php
+
+MyLib::deprecatedmethod();
+MyLib::nonDeprecatedMethod();
+MyLib::deprecatedMethod();
+~~~~~~~~~~
+warning:3:1
+warning:5:1
+~~~~~~~~~~
+~~~~~~~~~~
+{
+ "config": {
+ "xhpast.deprecated.functions": {
+ "MyLib::deprecatedMethod": "This static method is deprecated."
+ }
+ }
+}

File Metadata

Mime Type
text/plain
Expires
Thu, Mar 27, 11:49 PM (6 d, 20 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7223986
Default Alt Text
D17232.id.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility