Page MenuHomePhabricator

D14657.diff
No OneTemporary

D14657.diff

diff --git a/src/applications/phame/controller/blog/PhameBlogManageController.php b/src/applications/phame/controller/blog/PhameBlogManageController.php
--- a/src/applications/phame/controller/blog/PhameBlogManageController.php
+++ b/src/applications/phame/controller/blog/PhameBlogManageController.php
@@ -80,13 +80,18 @@
->setObject($blog)
->setActionList($actions);
- $properties->addProperty(
- pht('Skin'),
- $blog->getSkin());
+ $skin = $blog->getSkin();
+ if (!$skin) {
+ $skin = pht('(No external skin)');
+ }
- $properties->addProperty(
- pht('Domain'),
- $blog->getDomain());
+ $domain = $blog->getDomain();
+ if (!$domain) {
+ $domain = pht('(No external domain)');
+ }
+
+ $properties->addProperty(pht('Skin'), $skin);
+ $properties->addProperty(pht('Domain'), $domain);
$feed_uri = PhabricatorEnv::getProductionURI(
$this->getApplicationURI('blog/feed/'.$blog->getID().'/'));
diff --git a/src/applications/phame/controller/blog/PhameBlogProfilePictureController.php b/src/applications/phame/controller/blog/PhameBlogProfilePictureController.php
--- a/src/applications/phame/controller/blog/PhameBlogProfilePictureController.php
+++ b/src/applications/phame/controller/blog/PhameBlogProfilePictureController.php
@@ -25,7 +25,7 @@
return new Aphront404Response();
}
- $blog_uri = '/phame/blog/view/'.$id;
+ $blog_uri = '/phame/blog/manage/'.$id;
$supported_formats = PhabricatorFile::getTransformableImageFormats();
$e_file = true;
diff --git a/src/applications/phame/view/PhamePostListView.php b/src/applications/phame/view/PhamePostListView.php
--- a/src/applications/phame/view/PhamePostListView.php
+++ b/src/applications/phame/view/PhamePostListView.php
@@ -57,7 +57,7 @@
$phame_post = PhabricatorMarkupEngine::summarize($post->getBody());
$phame_post = new PHUIRemarkupView($viewer, $phame_post);
} else {
- $phame_post = phutil_tag('em', array(), pht('Empty Post'));
+ $phame_post = phutil_tag('em', array(), pht('(Empty Post)'));
}
$blogger = phutil_tag('strong', array(), $blogger);
@@ -101,6 +101,7 @@
if (empty($list)) {
$list = id(new PHUIInfoView())
+ ->setSeverity(PHUIInfoView::SEVERITY_NODATA)
->appendChild($nodata);
}

File Metadata

Mime Type
text/plain
Expires
Thu, Mar 27, 9:19 PM (2 w, 20 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7724881
Default Alt Text
D14657.diff (2 KB)

Event Timeline