D17172.id41300.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D17172.id41300.diff
View Options

	diff --git a/src/applications/differential/conduit/DifferentialQueryDiffsConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialQueryDiffsConduitAPIMethod.php
	--- a/src/applications/differential/conduit/DifferentialQueryDiffsConduitAPIMethod.php
	+++ b/src/applications/differential/conduit/DifferentialQueryDiffsConduitAPIMethod.php
	@@ -26,16 +26,27 @@
	$ids = $request->getValue('ids', array());
	$revision_ids = $request->getValue('revisionIDs', array());

	- $diffs = array();
	- if ($ids \|\| $revision_ids) {
	- $diffs = id(new DifferentialDiffQuery())
	- ->setViewer($request->getUser())
	- ->withIDs($ids)
	- ->withRevisionIDs($revision_ids)
	- ->needChangesets(true)
	- ->execute();
	+ if (!$ids && !$revision_ids) {
	+ // This method just returns nothing if you pass no constraints because
	+ // pagination hadn't been invented yet in 2008 when this method was
	+ // written.
	+ return array();
	}

	+ $query = id(new DifferentialDiffQuery())
	+ ->setViewer($request->getUser())
	+ ->needChangesets(true);
	+
	+ if ($ids) {
	+ $query->withIDs($ids);
	+ }
	+
	+ if ($revision_ids) {
	+ $query->withRevisionIDs($revision_ids);
	+ }
	+
	+ $diffs = $query->execute();
	+
	return mpull($diffs, 'getDiffDict', 'getID');
	}