Page MenuHomePhabricator
Files F15440387

D20898.id49811.diff
No OneTemporary
Actions

D20898.id49811.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -10,7 +10,7 @@
'conpherence.pkg.css' => '3c8a0668',
'conpherence.pkg.js' => '020aebcf',
'core.pkg.css' => '77de226f',
- 'core.pkg.js' => '6e5c894f',
+ 'core.pkg.js' => '705aec2c',
'differential.pkg.css' => '607c84be',
'differential.pkg.js' => '1b97518d',
'diffusion.pkg.css' => '42c75c37',
@@ -448,7 +448,7 @@
'rsrc/js/application/uiexample/notification-example.js' => '29819b75',
'rsrc/js/core/Busy.js' => '5202e831',
'rsrc/js/core/DragAndDropFileUpload.js' => '4370900d',
- 'rsrc/js/core/DraggableList.js' => 'c9ad6f70',
+ 'rsrc/js/core/DraggableList.js' => '0169e425',
'rsrc/js/core/Favicon.js' => '7930776a',
'rsrc/js/core/FileUpload.js' => 'ab85e184',
'rsrc/js/core/Hovercard.js' => '074f0783',
@@ -777,7 +777,7 @@
'phabricator-diff-changeset-list' => '0f5c016d',
'phabricator-diff-inline' => 'a4a14a94',
'phabricator-drag-and-drop-file-upload' => '4370900d',
- 'phabricator-draggable-list' => 'c9ad6f70',
+ 'phabricator-draggable-list' => '0169e425',
'phabricator-fatal-config-template-css' => '20babf50',
'phabricator-favicon' => '7930776a',
'phabricator-feed-css' => 'd8b6e3f8',
@@ -920,6 +920,14 @@
'javelin-uri',
'phabricator-notification',
),
+ '0169e425' => array(
+ 'javelin-install',
+ 'javelin-dom',
+ 'javelin-stratcom',
+ 'javelin-util',
+ 'javelin-vector',
+ 'javelin-magical-init',
+ ),
'022516b4' => array(
'javelin-install',
'javelin-util',
@@ -2032,14 +2040,6 @@
'javelin-util',
'phabricator-keyboard-shortcut-manager',
),
- 'c9ad6f70' => array(
- 'javelin-install',
- 'javelin-dom',
- 'javelin-stratcom',
- 'javelin-util',
- 'javelin-vector',
- 'javelin-magical-init',
- ),
'cf32921f' => array(
'javelin-behavior',
'javelin-dom',
diff --git a/src/view/phui/PHUIObjectItemView.php b/src/view/phui/PHUIObjectItemView.php
--- a/src/view/phui/PHUIObjectItemView.php
+++ b/src/view/phui/PHUIObjectItemView.php
@@ -379,10 +379,11 @@
if ($this->objectName) {
$header_name[] = array(
- phutil_tag(
+ javelin_tag(
'span',
array(
'class' => 'phui-oi-objname',
+ 'sigil' => 'ungrabbable',
),
$this->objectName),
' ',
diff --git a/webroot/rsrc/js/core/DraggableList.js b/webroot/rsrc/js/core/DraggableList.js
--- a/webroot/rsrc/js/core/DraggableList.js
+++ b/webroot/rsrc/js/core/DraggableList.js
@@ -181,6 +181,15 @@
return;
}
+ // See T13452. If this is an ungrabble part of the item, don't start a
+ // drag. We use this to allow users to select text on cards.
+ var target = e.getTarget();
+ if (target) {
+ if (JX.Stratcom.hasSigil(target, 'ungrabbable')) {
+ return;
+ }
+ }
+
if (JX.Stratcom.pass()) {
// Let other handlers deal with this event before we do.
return;

File Metadata

Mime Type
text/plain
Expires
Thu, Mar 27, 12:33 PM (2 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7390404
Default Alt Text
D20898.id49811.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility