Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15438820
D15806.id38074.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D15806.id38074.diff
View Options
diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -8,7 +8,7 @@
return array(
'names' => array(
'core.pkg.css' => '04a95108',
- 'core.pkg.js' => '37344f3c',
+ 'core.pkg.js' => 'fe72017f',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '7ba78475',
'differential.pkg.js' => 'd0cd0df6',
@@ -232,7 +232,7 @@
'rsrc/externals/javelin/lib/DOM.js' => '805b806a',
'rsrc/externals/javelin/lib/History.js' => 'd4505101',
'rsrc/externals/javelin/lib/JSON.js' => '69adf288',
- 'rsrc/externals/javelin/lib/Leader.js' => 'b4ba945c',
+ 'rsrc/externals/javelin/lib/Leader.js' => 'e00dff47',
'rsrc/externals/javelin/lib/Mask.js' => '8a41885b',
'rsrc/externals/javelin/lib/Quicksand.js' => '6b8ef10b',
'rsrc/externals/javelin/lib/Request.js' => '94b750d2',
@@ -704,7 +704,7 @@
'javelin-history' => 'd4505101',
'javelin-install' => '05270951',
'javelin-json' => '69adf288',
- 'javelin-leader' => 'b4ba945c',
+ 'javelin-leader' => 'e00dff47',
'javelin-magical-init' => '3010e992',
'javelin-mask' => '8a41885b',
'javelin-quicksand' => '6b8ef10b',
@@ -1772,9 +1772,6 @@
'javelin-typeahead-preloaded-source',
'javelin-util',
),
- 'b4ba945c' => array(
- 'javelin-install',
- ),
'b59e1e96' => array(
'javelin-behavior',
'javelin-stratcom',
@@ -1985,6 +1982,9 @@
'df5e11d2' => array(
'javelin-install',
),
+ 'e00dff47' => array(
+ 'javelin-install',
+ ),
'e10f8e18' => array(
'javelin-behavior',
'javelin-dom',
diff --git a/webroot/rsrc/externals/javelin/lib/Leader.js b/webroot/rsrc/externals/javelin/lib/Leader.js
--- a/webroot/rsrc/externals/javelin/lib/Leader.js
+++ b/webroot/rsrc/externals/javelin/lib/Leader.js
@@ -118,6 +118,10 @@
// Read the current leadership lease.
var lease = self._read();
+ // Stagger these delays so that they are unlikely to race one another.
+ var expire_delay = 50;
+ var usurp_delay = 75;
+
// If the lease is good, we're all set.
var now = +new Date();
if (lease.until > now) {
@@ -135,15 +139,12 @@
} else {
// Set a callback to try to become the leader shortly after the
- // current lease expires. This lets us recover from cases where the
- // leader goes missing quickly.
- if (self._timeoout) {
- window.clearTimeout(self._timeout);
- self._timeout = null;
+ // current lease expires. This lets us quickly recover from cases
+ // where the leader goes missing.
+ if (!self._timeout) {
+ var usurp_at = (lease.until - now) + usurp_delay;
+ self._timeout = window.setTimeout(self._usurp, usurp_at);
}
- self._timeout = window.setTimeout(
- self._usurp,
- (lease.until - now) + 50);
follower_callback();
}
@@ -174,7 +175,7 @@
window.setTimeout(
JX.bind(null, self._callIf, leader_callback, follower_callback),
- 50);
+ expire_delay);
},
@@ -305,6 +306,12 @@
*/
_usurp: function() {
var self = JX.Leader;
+
+ if (self._timeout) {
+ window.clearTimeout(self._timeout);
+ self._timeout = null;
+ }
+
self.call(JX.bag);
},
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Mar 27, 3:50 AM (3 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7486930
Default Alt Text
D15806.id38074.diff (3 KB)
Attached To
Mode
D15806: Probably improve behavior around duplicate notifications
Attached
Detach File
Event Timeline
Log In to Comment