Page MenuHomePhabricator
Files F15437481

D18813.diff
No OneTemporary
Actions

D18813.diff
View Options

diff --git a/src/applications/diffusion/controller/DiffusionCommitController.php b/src/applications/diffusion/controller/DiffusionCommitController.php
--- a/src/applications/diffusion/controller/DiffusionCommitController.php
+++ b/src/applications/diffusion/controller/DiffusionCommitController.php
@@ -438,7 +438,8 @@
$repository = $drequest->getRepository();
$view = id(new PHUIPropertyListView())
- ->setUser($this->getRequest()->getUser());
+ ->setUser($this->getRequest()->getUser())
+ ->setObject($commit);
$edge_query = id(new PhabricatorEdgeQuery())
->withSourcePHIDs(array($commit_phid))
diff --git a/src/applications/project/events/PhabricatorProjectUIEventListener.php b/src/applications/project/events/PhabricatorProjectUIEventListener.php
--- a/src/applications/project/events/PhabricatorProjectUIEventListener.php
+++ b/src/applications/project/events/PhabricatorProjectUIEventListener.php
@@ -8,8 +8,16 @@
}
public function handleEvent(PhutilEvent $event) {
+ $object = $event->getValue('object');
+
switch ($event->getType()) {
case PhabricatorEventType::TYPE_UI_WILLRENDERPROPERTIES:
+ // Hacky solution so that property list view on Diffusion
+ // commits shows build status, but not Projects, Subscriptions,
+ // or Tokens.
+ if ($object instanceof PhabricatorRepositoryCommit) {
+ return;
+ }
$this->handlePropertyEvent($event);
break;
}
diff --git a/src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php b/src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php
--- a/src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php
+++ b/src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php
@@ -9,11 +9,19 @@
}
public function handleEvent(PhutilEvent $event) {
+ $object = $event->getValue('object');
+
switch ($event->getType()) {
case PhabricatorEventType::TYPE_UI_DIDRENDERACTIONS:
$this->handleActionEvent($event);
break;
case PhabricatorEventType::TYPE_UI_WILLRENDERPROPERTIES:
+ // Hacky solution so that property list view on Diffusion
+ // commits shows build status, but not Projects, Subscriptions,
+ // or Tokens.
+ if ($object instanceof PhabricatorRepositoryCommit) {
+ return;
+ }
$this->handlePropertyEvent($event);
break;
}
diff --git a/src/applications/tokens/event/PhabricatorTokenUIEventListener.php b/src/applications/tokens/event/PhabricatorTokenUIEventListener.php
--- a/src/applications/tokens/event/PhabricatorTokenUIEventListener.php
+++ b/src/applications/tokens/event/PhabricatorTokenUIEventListener.php
@@ -9,11 +9,19 @@
}
public function handleEvent(PhutilEvent $event) {
+ $object = $event->getValue('object');
+
switch ($event->getType()) {
case PhabricatorEventType::TYPE_UI_DIDRENDERACTIONS:
$this->handleActionEvent($event);
break;
case PhabricatorEventType::TYPE_UI_WILLRENDERPROPERTIES:
+ // Hacky solution so that property list view on Diffusion
+ // commits shows build status, but not Projects, Subscriptions,
+ // or Tokens.
+ if ($object instanceof PhabricatorRepositoryCommit) {
+ return;
+ }
$this->handlePropertyEvent($event);
break;
}

File Metadata

Mime Type
text/plain
Expires
Wed, Mar 26, 7:44 PM (3 d, 21 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7708751
Default Alt Text
D18813.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility