Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15436207
D19815.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
847 B
Referenced Files
None
Subscribers
None
D19815.id.diff
View Options
diff --git a/src/future/exec/ExecFuture.php b/src/future/exec/ExecFuture.php
--- a/src/future/exec/ExecFuture.php
+++ b/src/future/exec/ExecFuture.php
@@ -366,8 +366,19 @@
list($err, $stdout, $stderr) = $this->resolve($timeout);
if ($err) {
$cmd = $this->command;
+
+ if ($this->getWasKilledByTimeout()) {
+ // NOTE: The timeout can be a float and PhutilNumber only handles
+ // integers, so just use "%s" to render it.
+ $message = pht(
+ 'Command killed by timeout after running for more than %s seconds.',
+ $this->terminateTimeout);
+ } else {
+ $message = pht('Command failed with error #%d!', $err);
+ }
+
throw new CommandException(
- pht('Command failed with error #%d!', $err),
+ $message,
$cmd,
$err,
$stdout,
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Mar 26, 12:36 PM (4 w, 2 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7721961
Default Alt Text
D19815.id.diff (847 B)
Attached To
Mode
D19815: When a command is killed by a timeout, make the human-readable error more clear
Attached
Detach File
Event Timeline
Log In to Comment