Page MenuHomePhabricator

D18075.id.diff
No OneTemporary

D18075.id.diff

diff --git a/src/applications/differential/storage/DifferentialDiff.php b/src/applications/differential/storage/DifferentialDiff.php
--- a/src/applications/differential/storage/DifferentialDiff.php
+++ b/src/applications/differential/storage/DifferentialDiff.php
@@ -642,6 +642,17 @@
return 'HEAD';
}
+ public function getBuildkiteAuthor() {
+ $author = id(new PhabricatorUser())->loadOneWhere(
+ 'phid = %s',
+ $this->getAuthorPHID());
+
+ return array(
+ 'name' => $author->getRealName(),
+ 'email' => $author->loadPrimaryEmailAddress(),
+ );
+ }
+
public function getStagingRef() {
// TODO: We're just hoping to get lucky. Instead, `arc` should store
diff --git a/src/applications/harbormaster/interface/HarbormasterBuildkiteBuildableInterface.php b/src/applications/harbormaster/interface/HarbormasterBuildkiteBuildableInterface.php
--- a/src/applications/harbormaster/interface/HarbormasterBuildkiteBuildableInterface.php
+++ b/src/applications/harbormaster/interface/HarbormasterBuildkiteBuildableInterface.php
@@ -7,5 +7,6 @@
public function getBuildkiteBranch();
public function getBuildkiteCommit();
+ public function getBuildkiteAuthor();
}
diff --git a/src/applications/harbormaster/step/HarbormasterBuildkiteBuildStepImplementation.php b/src/applications/harbormaster/step/HarbormasterBuildkiteBuildStepImplementation.php
--- a/src/applications/harbormaster/step/HarbormasterBuildkiteBuildStepImplementation.php
+++ b/src/applications/harbormaster/step/HarbormasterBuildkiteBuildStepImplementation.php
@@ -91,6 +91,7 @@
$data_structure = array(
'commit' => $object->getBuildkiteCommit(),
'branch' => $object->getBuildkiteBranch(),
+ 'author' => $object->getBuildkiteAuthor(),
'message' => pht(
'Harbormaster Build %s ("%s") for %s',
$build->getID(),
diff --git a/src/applications/repository/storage/PhabricatorRepositoryCommit.php b/src/applications/repository/storage/PhabricatorRepositoryCommit.php
--- a/src/applications/repository/storage/PhabricatorRepositoryCommit.php
+++ b/src/applications/repository/storage/PhabricatorRepositoryCommit.php
@@ -628,6 +628,16 @@
return $this->getCommitIdentifier();
}
+ public function getBuildkiteAuthor() {
+ $author = id(new PhabricatorUser())->loadOneWhere(
+ 'phid = %s',
+ $this->getAuthorPHID());
+
+ return array(
+ 'name' => $author->getRealName(),
+ 'email' => $author->loadPrimaryEmailAddress(),
+ );
+ }
/* -( PhabricatorCustomFieldInterface )------------------------------------ */

File Metadata

Mime Type
text/plain
Expires
Wed, Mar 26, 8:57 AM (4 d, 20 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7382364
Default Alt Text
D18075.id.diff (2 KB)

Event Timeline