Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15434716
D17082.id41074.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D17082.id41074.diff
View Options
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -582,7 +582,6 @@
'DifferentialUnitStatus' => 'applications/differential/constants/DifferentialUnitStatus.php',
'DifferentialUnitTestResult' => 'applications/differential/constants/DifferentialUnitTestResult.php',
'DifferentialUpdateRevisionConduitAPIMethod' => 'applications/differential/conduit/DifferentialUpdateRevisionConduitAPIMethod.php',
- 'DifferentialViewPolicyField' => 'applications/differential/customfield/DifferentialViewPolicyField.php',
'DiffusionAuditorDatasource' => 'applications/diffusion/typeahead/DiffusionAuditorDatasource.php',
'DiffusionAuditorFunctionDatasource' => 'applications/diffusion/typeahead/DiffusionAuditorFunctionDatasource.php',
'DiffusionAuditorsAddAuditorsHeraldAction' => 'applications/diffusion/herald/DiffusionAuditorsAddAuditorsHeraldAction.php',
@@ -5243,7 +5242,6 @@
'DifferentialUnitStatus' => 'Phobject',
'DifferentialUnitTestResult' => 'Phobject',
'DifferentialUpdateRevisionConduitAPIMethod' => 'DifferentialConduitAPIMethod',
- 'DifferentialViewPolicyField' => 'DifferentialCoreCustomField',
'DiffusionAuditorDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
'DiffusionAuditorFunctionDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
'DiffusionAuditorsAddAuditorsHeraldAction' => 'DiffusionAuditorsHeraldAction',
diff --git a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
--- a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
+++ b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
@@ -31,7 +31,6 @@
new DifferentialReviewersField(),
new DifferentialProjectReviewersField(),
new DifferentialRepositoryField(),
- new DifferentialViewPolicyField(),
new DifferentialManiphestTasksField(),
new DifferentialCommitsField(),
diff --git a/src/applications/differential/customfield/DifferentialViewPolicyField.php b/src/applications/differential/customfield/DifferentialViewPolicyField.php
deleted file mode 100644
--- a/src/applications/differential/customfield/DifferentialViewPolicyField.php
+++ /dev/null
@@ -1,50 +0,0 @@
-<?php
-
-final class DifferentialViewPolicyField
- extends DifferentialCoreCustomField {
-
- public function getFieldKey() {
- return 'differential:view-policy';
- }
-
- public function getFieldName() {
- return pht('View Policy');
- }
-
- public function getFieldDescription() {
- return pht('Controls visibility.');
- }
-
- protected function readValueFromRevision(
- DifferentialRevision $revision) {
- return $revision->getViewPolicy();
- }
-
- public function readValueFromRequest(AphrontRequest $request) {
- $this->setValue($request->getStr($this->getFieldKey()));
- }
-
- public function renderEditControl(array $handles) {
- $viewer = $this->getViewer();
- $revision = $this->getObject();
-
- $policies = id(new PhabricatorPolicyQuery())
- ->setViewer($viewer)
- ->setObject($revision)
- ->execute();
-
- return id(new AphrontFormPolicyControl())
- ->setUser($viewer)
- ->setCapability(PhabricatorPolicyCapability::CAN_VIEW)
- ->setPolicyObject($revision)
- ->setPolicies($policies)
- ->setName($this->getFieldKey())
- ->setValue($this->getValue())
- ->setError($this->getFieldError());
- }
-
- public function getApplicationTransactionType() {
- return PhabricatorTransactions::TYPE_VIEW_POLICY;
- }
-
-}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Mar 26, 4:57 AM (4 w, 6 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7709094
Default Alt Text
D17082.id41074.diff (3 KB)
Attached To
Mode
D17082: Remove Differential "View Policy" field
Attached
Detach File
Event Timeline
Log In to Comment