Page MenuHomePhabricator
Files F15432647

D19684.id.diff
No OneTemporary
Actions

D19684.id.diff
View Options

diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
--- a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
+++ b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
@@ -23,6 +23,7 @@
private $fullWidth;
private $infoView;
private $editEngineLock;
+ private $noBorder;
private $currentVersion;
private $versionedDraft;
@@ -243,7 +244,6 @@
$comment_box = id(new PHUIObjectBoxView())
->setFlush(true)
- ->setNoBorder(true)
->addClass('phui-comment-form-view')
->addSigil('phui-comment-form')
->appendChild(
diff --git a/src/view/phui/PHUIObjectBoxView.php b/src/view/phui/PHUIObjectBoxView.php
--- a/src/view/phui/PHUIObjectBoxView.php
+++ b/src/view/phui/PHUIObjectBoxView.php
@@ -25,7 +25,6 @@
private $showHideHref;
private $showHideContent;
private $showHideOpen;
- private $noBorder;
private $propertyLists = array();
@@ -148,11 +147,6 @@
return $this;
}
- public function setNoBorder($no_border) {
- $this->noBorder = $no_border;
- return $this;
- }
-
public function setValidationException(
PhabricatorApplicationTransactionValidationException $ex = null) {
$this->validationException = $ex;
@@ -162,9 +156,7 @@
protected function getTagAttributes() {
$classes = array();
$classes[] = 'phui-box';
- if (!$this->noBorder) {
- $classes[] = 'phui-box-border';
- }
+ $classes[] = 'phui-box-border';
$classes[] = 'phui-object-box';
$classes[] = 'mlt mll mlr';
diff --git a/src/view/phui/PHUITimelineEventView.php b/src/view/phui/PHUITimelineEventView.php
--- a/src/view/phui/PHUITimelineEventView.php
+++ b/src/view/phui/PHUITimelineEventView.php
@@ -402,7 +402,7 @@
$wedge = phutil_tag(
'div',
array(
- 'class' => 'phui-timeline-wedge phui-timeline-border',
+ 'class' => 'phui-timeline-wedge',
'style' => (nonempty($image_uri)) ? '' : 'display: none;',
),
'');
@@ -461,7 +461,7 @@
$content = phutil_tag(
'div',
array(
- 'class' => 'phui-timeline-group phui-timeline-border',
+ 'class' => 'phui-timeline-group',
),
$content);

File Metadata

Mime Type
text/plain
Expires
Mar 25 2025, 7:07 PM (4 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7389356
Default Alt Text
D19684.id.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility