Page MenuHomePhabricator

D19608.id.diff
No OneTemporary

D19608.id.diff

diff --git a/src/applications/transactions/editengine/PhabricatorEditEngine.php b/src/applications/transactions/editengine/PhabricatorEditEngine.php
--- a/src/applications/transactions/editengine/PhabricatorEditEngine.php
+++ b/src/applications/transactions/editengine/PhabricatorEditEngine.php
@@ -2003,7 +2003,19 @@
$identifier = $request->getValue('objectIdentifier');
if ($identifier) {
$this->setIsCreate(false);
- $object = $this->newObjectFromIdentifier($identifier);
+
+ // After T13186, each transaction can individually weaken or replace the
+ // capabilities required to apply it, so we no longer need CAN_EDIT to
+ // attempt to apply transactions to objects. In practice, almost all
+ // transactions require CAN_EDIT so we won't get very far if we don't
+ // have it.
+ $capabilities = array(
+ PhabricatorPolicyCapability::CAN_VIEW,
+ );
+
+ $object = $this->newObjectFromIdentifier(
+ $identifier,
+ $capabilities);
} else {
$this->requireCreateCapability();

File Metadata

Mime Type
text/plain
Expires
Tue, Mar 25, 3:27 PM (1 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7611987
Default Alt Text
D19608.id.diff (1 KB)

Event Timeline