Page MenuHomePhabricator
Files F15431288

D21618.diff
No OneTemporary
Actions

D21618.diff
View Options

diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -340,32 +340,60 @@
pht('Failed to load revision from transaction finalization.'));
}
+ $active_diff = $new_revision->getActiveDiff();
+ $new_diff_phid = $active_diff->getPHID();
+
$object->attachReviewers($new_revision->getReviewers());
- $object->attachActiveDiff($new_revision->getActiveDiff());
+ $object->attachActiveDiff($active_diff);
$object->attachRepository($new_revision->getRepository());
+ $has_new_diff = false;
+ $should_index_paths = false;
+ $should_index_hashes = false;
+ $need_changesets = false;
+
foreach ($xactions as $xaction) {
switch ($xaction->getTransactionType()) {
case DifferentialRevisionUpdateTransaction::TRANSACTIONTYPE:
- $diff = $this->requireDiff($xaction->getNewValue(), true);
+ $need_changesets = true;
- $this->ownersDiff = $diff;
- $this->ownersChangesets = $diff->getChangesets();
+ $new_diff_phid = $xaction->getNewValue();
+ $has_new_diff = true;
- // Update these denormalized index tables when we attach a new
- // diff to a revision.
-
- $this->updateRevisionHashTable($object, $diff);
+ $should_index_paths = true;
+ $should_index_hashes = true;
+ break;
+ case DifferentialRevisionRepositoryTransaction::TRANSACTIONTYPE:
+ // The "AffectedPath" table denormalizes the repository, so we
+ // want to update the index if the repository changes.
- id(new DifferentialAffectedPathEngine())
- ->setRevision($object)
- ->setDiff($diff)
- ->updateAffectedPaths();
+ $need_changesets = true;
+ $should_index_paths = true;
break;
}
}
+ if ($need_changesets) {
+ $new_diff = $this->requireDiff($new_diff_phid, true);
+
+ if ($should_index_paths) {
+ id(new DifferentialAffectedPathEngine())
+ ->setRevision($object)
+ ->setDiff($new_diff)
+ ->updateAffectedPaths();
+ }
+
+ if ($should_index_hashes) {
+ $this->updateRevisionHashTable($object, $new_diff);
+ }
+
+ if ($has_new_diff) {
+ $this->ownersDiff = $new_diff;
+ $this->ownersChangesets = $new_diff->getChangesets();
+ }
+ }
+
$xactions = $this->updateReviewStatus($object, $xactions);
$this->markReviewerComments($object, $xactions);

File Metadata

Mime Type
text/plain
Expires
Tue, Mar 25, 11:35 AM (1 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7710798
Default Alt Text
D21618.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility