Page MenuHomePhabricator
Files F15430435

D17077.id41067.diff
No OneTemporary
Actions

D17077.id41067.diff
View Options

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -473,7 +473,6 @@
'DifferentialMailView' => 'applications/differential/mail/DifferentialMailView.php',
'DifferentialManiphestTasksField' => 'applications/differential/customfield/DifferentialManiphestTasksField.php',
'DifferentialModernHunk' => 'applications/differential/storage/DifferentialModernHunk.php',
- 'DifferentialParentRevisionsField' => 'applications/differential/customfield/DifferentialParentRevisionsField.php',
'DifferentialParseCacheGarbageCollector' => 'applications/differential/garbagecollector/DifferentialParseCacheGarbageCollector.php',
'DifferentialParseCommitMessageConduitAPIMethod' => 'applications/differential/conduit/DifferentialParseCommitMessageConduitAPIMethod.php',
'DifferentialParseRenderTestCase' => 'applications/differential/__tests__/DifferentialParseRenderTestCase.php',
@@ -5123,7 +5122,6 @@
'DifferentialMailView' => 'Phobject',
'DifferentialManiphestTasksField' => 'DifferentialCoreCustomField',
'DifferentialModernHunk' => 'DifferentialHunk',
- 'DifferentialParentRevisionsField' => 'DifferentialCustomField',
'DifferentialParseCacheGarbageCollector' => 'PhabricatorGarbageCollector',
'DifferentialParseCommitMessageConduitAPIMethod' => 'DifferentialConduitAPIMethod',
'DifferentialParseRenderTestCase' => 'PhabricatorTestCase',
diff --git a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
--- a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
+++ b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
@@ -36,7 +36,6 @@
new DifferentialProjectsField(),
new DifferentialViewPolicyField(),
- new DifferentialParentRevisionsField(),
new DifferentialManiphestTasksField(),
new DifferentialCommitsField(),
diff --git a/src/applications/differential/customfield/DifferentialParentRevisionsField.php b/src/applications/differential/customfield/DifferentialParentRevisionsField.php
deleted file mode 100644
--- a/src/applications/differential/customfield/DifferentialParentRevisionsField.php
+++ /dev/null
@@ -1,44 +0,0 @@
-<?php
-
-final class DifferentialParentRevisionsField
- extends DifferentialCustomField {
-
- public function getFieldKey() {
- return 'differential:depends-on';
- }
-
- public function getFieldName() {
- return pht('Parent Revisions');
- }
-
- public function canDisableField() {
- return false;
- }
-
- public function getFieldDescription() {
- return pht('Lists revisions this one depends on.');
- }
-
- public function getProTips() {
- return array(
- pht(
- 'Create a dependency between revisions by writing '.
- '"%s" in your summary.',
- 'Depends on D123'),
- );
- }
-
- public function shouldAppearInConduitDictionary() {
- // To improve performance, we exclude this field from Conduit results.
- // See T11404 for discussion. In modern "differential.revision.search",
- // this information is available efficiently as an attachment.
- return false;
- }
-
- public function getConduitDictionaryValue() {
- return PhabricatorEdgeQuery::loadDestinationPHIDs(
- $this->getObject()->getPHID(),
- DifferentialRevisionDependsOnRevisionEdgeType::EDGECONST);
- }
-
-}

File Metadata

Mime Type
text/plain
Expires
Tue, Mar 25, 7:39 AM (3 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7640785
Default Alt Text
D17077.id41067.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility