Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15430270
D9473.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
876 B
Referenced Files
None
Subscribers
None
D9473.diff
View Options
diff --git a/src/lint/linter/ArcanistPEP8Linter.php b/src/lint/linter/ArcanistPEP8Linter.php
--- a/src/lint/linter/ArcanistPEP8Linter.php
+++ b/src/lint/linter/ArcanistPEP8Linter.php
@@ -109,12 +109,7 @@
if (preg_match('/^W/', $code)) {
return ArcanistLintSeverity::SEVERITY_WARNING;
} else {
-
- // TODO: Once severities/.arclint are more usable, restore this to
- // "ERROR".
- // return ArcanistLintSeverity::SEVERITY_ERROR;
-
- return ArcanistLintSeverity::SEVERITY_WARNING;
+ return ArcanistLintSeverity::SEVERITY_ERROR;
}
}
diff --git a/src/lint/linter/__tests__/pep8/imports.lint-test b/src/lint/linter/__tests__/pep8/imports.lint-test
--- a/src/lint/linter/__tests__/pep8/imports.lint-test
+++ b/src/lint/linter/__tests__/pep8/imports.lint-test
@@ -1,3 +1,3 @@
import os, sys
~~~~~~~~~~
-warning:1:10
+error:1:10
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Mar 25, 6:51 AM (1 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7684607
Default Alt Text
D9473.diff (876 B)
Attached To
Mode
D9473: Restore PEP8 errors.
Attached
Detach File
Event Timeline
Log In to Comment