Page MenuHomePhabricator
Files F15430139

D10537.id26926.diff
No OneTemporary
Actions

D10537.id26926.diff
View Options

diff --git a/src/lint/linter/ArcanistXHPASTLinter.php b/src/lint/linter/ArcanistXHPASTLinter.php
--- a/src/lint/linter/ArcanistXHPASTLinter.php
+++ b/src/lint/linter/ArcanistXHPASTLinter.php
@@ -50,6 +50,7 @@
const LINT_ARRAY_SEPARATOR = 48;
const LINT_CONSTRUCTOR_PARENTHESES = 49;
const LINT_DUPLICATE_SWITCH_CASE = 50;
+ const LINT_CALL_TIME_PASS_BY_REF = 51;
private $naminghook;
private $switchhook;
@@ -111,6 +112,7 @@
self::LINT_ARRAY_SEPARATOR => 'Array Separator',
self::LINT_CONSTRUCTOR_PARENTHESES => 'Constructor Parentheses',
self::LINT_DUPLICATE_SWITCH_CASE => 'Duplicate Case Statements',
+ self::LINT_CALL_TIME_PASS_BY_REF => 'Call-Time Pass-By-Reference',
);
}
@@ -201,7 +203,7 @@
public function getVersion() {
// The version number should be incremented whenever a new rule is added.
- return '12';
+ return '13';
}
protected function resolveFuture($path, Future $future) {
@@ -274,6 +276,7 @@
'lintArraySeparator' => self::LINT_ARRAY_SEPARATOR,
'lintConstructorParentheses' => self::LINT_CONSTRUCTOR_PARENTHESES,
'lintSwitchStatements' => self::LINT_DUPLICATE_SWITCH_CASE,
+ 'lintCallTimePassByReference' => self::LINT_CALL_TIME_PASS_BY_REF,
);
foreach ($method_codes as $method => $codes) {
@@ -2969,6 +2972,21 @@
}
}
+ protected function lintCallTimePassByReference(XHPASTNode $root) {
+ $nodes = $root->selectDescendantsOfType('n_CALL_PARAMETER_LIST');
+
+ foreach ($nodes as $node) {
+ $parameters = $node->selectDescendantsOfType('n_VARIABLE_REFERENCE');
+
+ foreach ($parameters as $parameter) {
+ $this->raiseLintAtNode(
+ $parameter,
+ self::LINT_CALL_TIME_PASS_BY_REF,
+ pht('Call-time pass-by-reference calls are prohibited.'));
+ }
+ }
+ }
+
public function getSuperGlobalNames() {
return array(
'$GLOBALS',
diff --git a/src/lint/linter/__tests__/xhpast/call-time-pass-by-reference.lint-test b/src/lint/linter/__tests__/xhpast/call-time-pass-by-reference.lint-test
new file mode 100644
--- /dev/null
+++ b/src/lint/linter/__tests__/xhpast/call-time-pass-by-reference.lint-test
@@ -0,0 +1,29 @@
+<?php
+class MyClass extends YourClass implements SomeInt {
+ function myfunc($var) {
+ echo $var;
+ }
+}
+
+$myvar = true;
+myfunc(&$myvar);
+myfunc($myvar);
+
+$this->myfunc(&$myvar);
+$this->myfunc($myvar);
+
+MyClass::myfunc(&$myvar);
+MyClass::myfunc($myvar);
+
+while (testfunc($var1, &$var2, $var3, &$var4) === false) {}
+
+sprintf('0%o', 0777 & $p);
+
+$foo(&$myvar);
+~~~~~~~~~~
+error:9:8
+error:12:15
+error:15:17
+error:18:24
+error:18:39
+error:22:6

File Metadata

Mime Type
text/plain
Expires
Tue, Mar 25, 6:12 AM (1 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7705674
Default Alt Text
D10537.id26926.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility