Page MenuHomePhabricator

D10961.id.diff
No OneTemporary

D10961.id.diff

diff --git a/src/applications/differential/view/DifferentialRevisionListView.php b/src/applications/differential/view/DifferentialRevisionListView.php
--- a/src/applications/differential/view/DifferentialRevisionListView.php
+++ b/src/applications/differential/view/DifferentialRevisionListView.php
@@ -121,9 +121,8 @@
}
$item->setObjectName('D'.$revision->getID());
- $item->setHeader(phutil_tag('a',
- array('href' => '/D'.$revision->getID()),
- $revision->getTitle()));
+ $item->setHeader($revision->getTitle());
+ $item->setHref('/D'.$revision->getID());
if (isset($icons['draft'])) {
$draft = id(new PHUIIconView())
diff --git a/src/applications/flag/query/PhabricatorFlagSearchEngine.php b/src/applications/flag/query/PhabricatorFlagSearchEngine.php
--- a/src/applications/flag/query/PhabricatorFlagSearchEngine.php
+++ b/src/applications/flag/query/PhabricatorFlagSearchEngine.php
@@ -149,7 +149,8 @@
$item = id(new PHUIObjectItemView())
->addHeadIcon($flag_icon)
- ->setHeader($flag->getHandle()->renderLink());
+ ->setHeader($flag->getHandle()->getFullName())
+ ->setHref($flag->getHandle()->getURI());
$item->addAction(
id(new PHUIListItemView())
diff --git a/src/view/phui/PHUIObjectItemView.php b/src/view/phui/PHUIObjectItemView.php
--- a/src/view/phui/PHUIObjectItemView.php
+++ b/src/view/phui/PHUIObjectItemView.php
@@ -329,6 +329,7 @@
array(
'href' => $this->href,
'class' => 'phui-object-item-link',
+ 'title' => ($this->href) ? $this->header : null,
),
$this->header);

File Metadata

Mime Type
text/plain
Expires
Tue, Mar 25, 1:55 AM (1 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7556545
Default Alt Text
D10961.id.diff (1 KB)

Event Timeline