Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15428472
D15543.id37469.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
787 B
Referenced Files
None
Subscribers
None
D15543.id37469.diff
View Options
diff --git a/src/view/phui/PHUITimelineView.php b/src/view/phui/PHUITimelineView.php
--- a/src/view/phui/PHUITimelineView.php
+++ b/src/view/phui/PHUITimelineView.php
@@ -224,7 +224,7 @@
$user_phids = array();
foreach ($events as $key => $event) {
- if (!$event->hasChildren()) {
+ if ($event->getIsPreview() || $event->getHideCommentOptions()) {
// This is a minor event, so we don't have space to show badges.
unset($events[$key]);
continue;
@@ -259,7 +259,9 @@
$awards = mgroup($awards, 'getRecipientPHID');
foreach ($events as $event) {
+
$author_awards = idx($awards, $event->getAuthorPHID(), array());
+
$badges = array();
foreach ($author_awards as $award) {
$badge = $award->getBadge();
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Mar 24, 8:34 PM (4 d, 29 m ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7719738
Default Alt Text
D15543.id37469.diff (787 B)
Attached To
Mode
D15543: Changing criteria for showing badges in object timeline view
Attached
Detach File
Event Timeline
Log In to Comment