Page MenuHomePhabricator
Files F15428428

D17052.id41018.diff
No OneTemporary
Actions

D17052.id41018.diff
View Options

diff --git a/src/aphront/configuration/AphrontApplicationConfiguration.php b/src/aphront/configuration/AphrontApplicationConfiguration.php
--- a/src/aphront/configuration/AphrontApplicationConfiguration.php
+++ b/src/aphront/configuration/AphrontApplicationConfiguration.php
@@ -303,18 +303,7 @@
phlog($unexpected_output);
if ($response instanceof AphrontWebpageResponse) {
- echo phutil_tag(
- 'div',
- array(
- 'style' =>
- 'background: #eeddff;'.
- 'white-space: pre-wrap;'.
- 'z-index: 200000;'.
- 'position: relative;'.
- 'padding: 8px;'.
- 'font-family: monospace',
- ),
- $unexpected_output);
+ $response->setUnexpectedOutput($unexpected_output);
}
}
diff --git a/src/aphront/response/AphrontWebpageResponse.php b/src/aphront/response/AphrontWebpageResponse.php
--- a/src/aphront/response/AphrontWebpageResponse.php
+++ b/src/aphront/response/AphrontWebpageResponse.php
@@ -3,14 +3,46 @@
final class AphrontWebpageResponse extends AphrontHTMLResponse {
private $content;
+ private $unexpectedOutput;
public function setContent($content) {
$this->content = $content;
return $this;
}
+ public function setUnexpectedOutput($unexpected_output) {
+ $this->unexpectedOutput = $unexpected_output;
+ return $this;
+ }
+
+ public function getUnexpectedOutput() {
+ return $this->unexpectedOutput;
+ }
+
public function buildResponseString() {
- return hsprintf('%s', $this->content);
+ $unexpected_output = $this->getUnexpectedOutput();
+ if (strlen($unexpected_output)) {
+ $style = array(
+ 'background: linear-gradient(180deg, #eeddff, #ddbbff);',
+ 'white-space: pre-wrap;',
+ 'z-index: 200000;',
+ 'position: relative;',
+ 'padding: 16px;',
+ 'font-family: monospace;',
+ 'text-shadow: 1px 1px 1px white;',
+ );
+
+ $unexpected_header = phutil_tag(
+ 'div',
+ array(
+ 'style' => implode(' ', $style),
+ ),
+ $unexpected_output);
+ } else {
+ $unexpected_header = '';
+ }
+
+ return hsprintf('%s%s', $unexpected_header, $this->content);
}
}

File Metadata

Mime Type
text/plain
Expires
Mon, Mar 24, 8:15 PM (1 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7617946
Default Alt Text
D17052.id41018.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility