D9723.id23347.diff
No OneTemporary
Actions

Size

706 B

Referenced Files

None

Subscribers

None

D9723.id23347.diff
View Options

	diff --git a/src/lint/linter/ArcanistChmodLinter.php b/src/lint/linter/ArcanistChmodLinter.php
	--- a/src/lint/linter/ArcanistChmodLinter.php
	+++ b/src/lint/linter/ArcanistChmodLinter.php
	@@ -46,6 +46,13 @@
	public function lintPath($path) {
	if (is_executable($path)) {
	if ($this->getEngine()->isBinaryFile($path)) {
	+ if (function_exists('exif_imagetype') && @exif_imagetype($path)) {
	+ $this->raiseLintAtPath(
	+ self::LINT_INVALID_EXECUTABLE,
	+ pht('Images should not be executable.'));
	+ return;
	+ }
	+
	// Path is a binary file, which makes it a valid executable.
	return;
	} else if ($this->getShebang($path)) {