Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15427054
D18950.id45449.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D18950.id45449.diff
View Options
diff --git a/src/applications/diffusion/herald/HeraldCommitAdapter.php b/src/applications/diffusion/herald/HeraldCommitAdapter.php
--- a/src/applications/diffusion/herald/HeraldCommitAdapter.php
+++ b/src/applications/diffusion/herald/HeraldCommitAdapter.php
@@ -135,13 +135,16 @@
}
public function loadAffectedPaths() {
+ $viewer = $this->getViewer();
+
if ($this->affectedPaths === null) {
$result = PhabricatorOwnerPathQuery::loadAffectedPaths(
$this->getRepository(),
$this->commit,
- PhabricatorUser::getOmnipotentUser());
+ $viewer);
$this->affectedPaths = $result;
}
+
return $this->affectedPaths;
}
@@ -172,6 +175,8 @@
}
public function loadDifferentialRevision() {
+ $viewer = $this->getViewer();
+
if ($this->affectedRevision === null) {
$this->affectedRevision = false;
@@ -189,7 +194,7 @@
$revision = id(new DifferentialRevisionQuery())
->withIDs(array($revision_id))
- ->setViewer(PhabricatorUser::getOmnipotentUser())
+ ->setViewer($viewer)
->needReviewers(true)
->executeOne();
if ($revision) {
@@ -197,6 +202,7 @@
}
}
}
+
return $this->affectedRevision;
}
@@ -323,7 +329,7 @@
}
private function callConduit($method, array $params) {
- $viewer = PhabricatorUser::getOmnipotentUser();
+ $viewer = $this->getViewer();
$drequest = DiffusionRequest::newFromDictionary(
array(
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mar 24 2025, 12:28 PM (6 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7223310
Default Alt Text
D18950.id45449.diff (1 KB)
Attached To
Mode
D18950: Use the configured viewer more consistently in the Herald commit adapter
Attached
Detach File
Event Timeline
Log In to Comment