Page MenuHomePhabricator

D20027.diff
No OneTemporary

D20027.diff

diff --git a/src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php b/src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php
--- a/src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php
+++ b/src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php
@@ -11,16 +11,23 @@
}
protected function executeChecks() {
- if (version_compare(phpversion(), 7, '>=') &&
- version_compare(phpversion(), 7.1, '<')) {
+ $version = phpversion();
+ if (version_compare($version, 7, '>=') &&
+ version_compare($version, 7.1, '<')) {
$message = pht(
- 'This version of Phabricator does not support PHP 7.0. You '.
- 'are running PHP %s. Upgrade to PHP 7.1 or newer.',
- phpversion());
+ 'You are running PHP version %s. Phabricator does not support PHP '.
+ 'versions between 7.0 and 7.1.'.
+ "\n\n".
+ 'PHP removed signal handling features that Phabricator requires in '.
+ 'PHP 7.0, and did not restore them until PHP 7.1.'.
+ "\n\n".
+ 'Upgrade to PHP 7.1 or newer (recommended) or downgrade to an older '.
+ 'version of PHP 5 (discouraged).',
+ $version);
$this->newIssue('php.version7')
->setIsFatal(true)
- ->setName(pht('PHP 7.0 Not Supported'))
+ ->setName(pht('PHP 7.0-7.1 Not Supported'))
->setMessage($message)
->addLink(
'https://phurl.io/u/php7',

File Metadata

Mime Type
text/plain
Expires
Mon, Mar 24, 10:57 AM (6 d, 22 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7356768
Default Alt Text
D20027.diff (1 KB)

Event Timeline