Page MenuHomePhabricator
Files F15424926

D13077.id31544.diff
No OneTemporary
Actions

D13077.id31544.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
*/
return array(
'names' => array(
- 'core.pkg.css' => 'f85a5ce0',
+ 'core.pkg.css' => '640158ac',
'core.pkg.js' => 'fbf1d615',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '30602b8c',
@@ -134,13 +134,13 @@
'rsrc/css/phui/phui-fontkit.css' => 'b664ac96',
'rsrc/css/phui/phui-form-view.css' => 'a0e8f168',
'rsrc/css/phui/phui-form.css' => 'f535f938',
- 'rsrc/css/phui/phui-header-view.css' => 'd7612da3',
+ 'rsrc/css/phui/phui-header-view.css' => 'c34679b1',
'rsrc/css/phui/phui-icon.css' => '88ba9081',
'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8',
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
'rsrc/css/phui/phui-info-view.css' => '33e54618',
'rsrc/css/phui/phui-list.css' => 'e448b6ba',
- 'rsrc/css/phui/phui-object-box.css' => '8eacbeed',
+ 'rsrc/css/phui/phui-object-box.css' => '047abfd1',
'rsrc/css/phui/phui-object-item-list-view.css' => '24ed8d94',
'rsrc/css/phui/phui-pinboard-view.css' => '55b27bc3',
'rsrc/css/phui/phui-property-list-view.css' => '1baf23eb',
@@ -769,14 +769,14 @@
'phui-fontkit-css' => 'b664ac96',
'phui-form-css' => 'f535f938',
'phui-form-view-css' => 'a0e8f168',
- 'phui-header-view-css' => 'd7612da3',
+ 'phui-header-view-css' => 'c34679b1',
'phui-icon-view-css' => '88ba9081',
'phui-image-mask-css' => '5a8b09c8',
'phui-info-panel-css' => '27ea50a1',
'phui-info-view-css' => '33e54618',
'phui-inline-comment-view-css' => 'aa16f165',
'phui-list-view-css' => 'e448b6ba',
- 'phui-object-box-css' => '8eacbeed',
+ 'phui-object-box-css' => '047abfd1',
'phui-object-item-list-view-css' => '24ed8d94',
'phui-pinboard-view-css' => '55b27bc3',
'phui-property-list-view-css' => '1baf23eb',
diff --git a/src/applications/diffusion/controller/DiffusionCommitController.php b/src/applications/diffusion/controller/DiffusionCommitController.php
--- a/src/applications/diffusion/controller/DiffusionCommitController.php
+++ b/src/applications/diffusion/controller/DiffusionCommitController.php
@@ -148,6 +148,7 @@
),
$message));
+ $headsup_view->setTall(true);
$object_box = id(new PHUIObjectBoxView())
->setHeader($headsup_view)
->addPropertyList($property_list)
diff --git a/src/view/phui/PHUIHeaderView.php b/src/view/phui/PHUIHeaderView.php
--- a/src/view/phui/PHUIHeaderView.php
+++ b/src/view/phui/PHUIHeaderView.php
@@ -13,6 +13,7 @@
private $headerIcon;
private $noBackground;
private $bleedHeader;
+ private $tall;
private $properties = array();
private $actionLinks = array();
private $buttonBar = null;
@@ -35,6 +36,11 @@
return $this;
}
+ public function setTall($tall) {
+ $this->tall = $tall;
+ return $this;
+ }
+
public function addTag(PHUITagView $tag) {
$this->tags[] = $tag;
return $this;
@@ -147,7 +153,8 @@
$classes[] = 'phui-bleed-header';
}
- if ($this->properties || $this->policyObject || $this->subheader) {
+ if ($this->properties || $this->policyObject ||
+ $this->subheader || $this->tall) {
$classes[] = 'phui-header-tall';
}
@@ -230,7 +237,12 @@
->setIconFont($this->headerIcon);
$left[] = $icon;
}
- $left[] = $this->header;
+ $left[] = phutil_tag(
+ 'span',
+ array(
+ 'class' => 'phui-header-header',
+ ),
+ $this->header);
if ($this->objectName) {
array_unshift(
diff --git a/webroot/rsrc/css/phui/phui-header-view.css b/webroot/rsrc/css/phui/phui-header-view.css
--- a/webroot/rsrc/css/phui/phui-header-view.css
+++ b/webroot/rsrc/css/phui/phui-header-view.css
@@ -70,6 +70,10 @@
position: relative;
}
+.phui-header-header {
+ line-height: 20px;
+}
+
.device-phone .phui-header-view {
font-size: 14px;
}
@@ -80,7 +84,7 @@
font-weight: 500;
}
-.phui-header-view .phui-header-col2 > a {
+.phui-header-view .phui-header-header a {
color: #000;
}
diff --git a/webroot/rsrc/css/phui/phui-object-box.css b/webroot/rsrc/css/phui/phui-object-box.css
--- a/webroot/rsrc/css/phui/phui-object-box.css
+++ b/webroot/rsrc/css/phui/phui-object-box.css
@@ -124,7 +124,3 @@
margin: 0;
padding: 0;
}
-
-.phui-box-border + .phui-box-border {
- border-top: 1px solid {$thinblueborder};
-}

File Metadata

Mime Type
text/plain
Expires
Mon, Mar 24, 1:10 AM (2 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7719334
Default Alt Text
D13077.id31544.diff (4 KB)

Event Timeline

Phabricator · Built by Phacility