Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15424180
D12527.id30073.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D12527.id30073.diff
View Options
diff --git a/src/applications/maniphest/query/ManiphestTaskSearchEngine.php b/src/applications/maniphest/query/ManiphestTaskSearchEngine.php
--- a/src/applications/maniphest/query/ManiphestTaskSearchEngine.php
+++ b/src/applications/maniphest/query/ManiphestTaskSearchEngine.php
@@ -55,7 +55,7 @@
$saved->setParameter(
'subscriberPHIDs',
- $this->readPHIDsFromRequest($request, 'subscribers'));
+ $this->readSubscribersFromRequest($request, 'subscribers'));
$saved->setParameter(
'statuses',
@@ -111,12 +111,21 @@
$query = id(new ManiphestTaskQuery())
->needProjectPHIDs(true);
- $author_phids = $saved->getParameter('authorPHIDs');
+ $viewer = $this->requireViewer();
+
+ $datasource = id(new PhabricatorTypeaheadUserParameterizedDatasource())
+ ->setViewer($viewer);
+
+ $author_phids = $saved->getParameter('authorPHIDs', array());
+ $author_phids = $datasource->evaluateTokens($author_phids);
if ($author_phids) {
$query->withAuthors($author_phids);
}
- $subscriber_phids = $saved->getParameter('subscriberPHIDs');
+ $datasource = id(new PhabricatorMetaMTAMailableFunctionDatasource())
+ ->setViewer($viewer);
+ $subscriber_phids = $saved->getParameter('subscriberPHIDs', array());
+ $subscriber_phids = $datasource->evaluateTokens($subscriber_phids);
if ($subscriber_phids) {
$query->withSubscribers($subscriber_phids);
}
@@ -274,13 +283,13 @@
->setValue($projects))
->appendControl(
id(new AphrontFormTokenizerControl())
- ->setDatasource(new PhabricatorPeopleDatasource())
+ ->setDatasource(new PhabricatorTypeaheadUserParameterizedDatasource())
->setName('authors')
->setLabel(pht('Authors'))
->setValue($author_phids))
->appendControl(
id(new AphrontFormTokenizerControl())
- ->setDatasource(new PhabricatorMetaMTAMailableDatasource())
+ ->setDatasource(new PhabricatorMetaMTAMailableFunctionDatasource())
->setName('subscribers')
->setLabel(pht('Subscribers'))
->setValue($subscriber_phids))
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Mar 23, 8:42 PM (1 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7719016
Default Alt Text
D12527.id30073.diff (2 KB)
Attached To
Mode
D12527: Use parameterized datasources for Maniphest authors and subscribers
Attached
Detach File
Event Timeline
Log In to Comment