D19304.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D19304.diff
View Options

	diff --git a/src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php b/src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php
	--- a/src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php
	+++ b/src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php
	@@ -276,10 +276,20 @@
	// format to make it easier to debug typeahead output.

	foreach ($sources as $key => $source) {
	+ // See T13119. Exclude proxy datasources from the dropdown since they
	+ // fatal if built like this without actually being configured with an
	+ // underlying datasource. This is a bit hacky but this is just a
	+ // debugging/development UI anyway.
	+ if ($source instanceof PhabricatorTypeaheadProxyDatasource) {
	+ unset($sources[$key]);
	+ continue;
	+ }
	+
	// This can happen with composite or generic sources.
	if (!$source->getDatasourceApplicationClass()) {
	continue;
	}
	+
	if (!PhabricatorApplication::isClassInstalledForViewer(
	$source->getDatasourceApplicationClass(),
	$viewer)) {