Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15422755
D20516.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
963 B
Referenced Files
None
Subscribers
None
D20516.diff
View Options
diff --git a/src/applications/project/controller/PhabricatorProjectController.php b/src/applications/project/controller/PhabricatorProjectController.php
--- a/src/applications/project/controller/PhabricatorProjectController.php
+++ b/src/applications/project/controller/PhabricatorProjectController.php
@@ -191,7 +191,13 @@
$view_list = $engine->newProfileMenuItemViewList();
- $view_list->setSelectedViewWithItemIdentifier($item_identifier);
+ // See PHI1247. If the "Workboard" item is removed from the menu, we will
+ // not be able to select it. This can happen if a user removes the item,
+ // then manually navigate to the workboard URI (or follows an older link).
+ // In this case, just render the menu with no selected item.
+ if ($view_list->getViewsWithItemIdentifier($item_identifier)) {
+ $view_list->setSelectedViewWithItemIdentifier($item_identifier);
+ }
$navigation = $view_list->newNavigationView();
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Mar 23, 10:36 AM (1 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7713468
Default Alt Text
D20516.diff (963 B)
Attached To
Mode
D20516: Fix a fatal when navigating to a Workboard after removing the Workboard menu item
Attached
Detach File
Event Timeline
Log In to Comment