Page MenuHomePhabricator

D20516.diff
No OneTemporary

D20516.diff

diff --git a/src/applications/project/controller/PhabricatorProjectController.php b/src/applications/project/controller/PhabricatorProjectController.php
--- a/src/applications/project/controller/PhabricatorProjectController.php
+++ b/src/applications/project/controller/PhabricatorProjectController.php
@@ -191,7 +191,13 @@
$view_list = $engine->newProfileMenuItemViewList();
- $view_list->setSelectedViewWithItemIdentifier($item_identifier);
+ // See PHI1247. If the "Workboard" item is removed from the menu, we will
+ // not be able to select it. This can happen if a user removes the item,
+ // then manually navigate to the workboard URI (or follows an older link).
+ // In this case, just render the menu with no selected item.
+ if ($view_list->getViewsWithItemIdentifier($item_identifier)) {
+ $view_list->setSelectedViewWithItemIdentifier($item_identifier);
+ }
$navigation = $view_list->newNavigationView();

File Metadata

Mime Type
text/plain
Expires
Sun, Mar 23, 10:36 AM (1 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7713468
Default Alt Text
D20516.diff (963 B)

Event Timeline