Page MenuHomePhabricator

D8553.id20301.diff
No OneTemporary

D8553.id20301.diff

diff --git a/src/aphront/console/plugin/DarkConsoleXHProfPlugin.php b/src/aphront/console/plugin/DarkConsoleXHProfPlugin.php
--- a/src/aphront/console/plugin/DarkConsoleXHProfPlugin.php
+++ b/src/aphront/console/plugin/DarkConsoleXHProfPlugin.php
@@ -43,7 +43,7 @@
$profile_uri = $data['profileURI'];
if (!DarkConsoleXHProfPluginAPI::isProfilerAvailable()) {
- $href = PhabricatorEnv::getDoclink('article/Installation_Guide.html');
+ $href = PhabricatorEnv::getDoclink('Installation Guide');
$install_guide = phutil_tag(
'a',
array(
diff --git a/src/applications/audit/application/PhabricatorApplicationAudit.php b/src/applications/audit/application/PhabricatorApplicationAudit.php
--- a/src/applications/audit/application/PhabricatorApplicationAudit.php
+++ b/src/applications/audit/application/PhabricatorApplicationAudit.php
@@ -15,7 +15,7 @@
}
public function getHelpURI() {
- return PhabricatorEnv::getDoclink('article/Audit_User_Guide.html');
+ return PhabricatorEnv::getDoclink('Audit User Guide');
}
public function getEventListeners() {
diff --git a/src/applications/conduit/application/PhabricatorApplicationConduit.php b/src/applications/conduit/application/PhabricatorApplicationConduit.php
--- a/src/applications/conduit/application/PhabricatorApplicationConduit.php
+++ b/src/applications/conduit/application/PhabricatorApplicationConduit.php
@@ -15,8 +15,7 @@
}
public function getHelpURI() {
- return PhabricatorEnv::getDoclink(
- 'article/Conduit_Technical_Documentation.html');
+ return PhabricatorEnv::getDoclink('Conduit Technical Documentation');
}
public function getShortDescription() {
diff --git a/src/applications/config/check/PhabricatorSetupCheckDaemons.php b/src/applications/config/check/PhabricatorSetupCheckDaemons.php
--- a/src/applications/config/check/PhabricatorSetupCheckDaemons.php
+++ b/src/applications/config/check/PhabricatorSetupCheckDaemons.php
@@ -13,7 +13,7 @@
if (!$task_daemon) {
$doc_href = PhabricatorEnv::getDocLink(
- 'article/Managing_Daemons_with_phd.html');
+ 'Managing Daemons with phd');
$summary = pht(
'You must start the Phabricator daemons to send email, rebuild '.
diff --git a/src/applications/config/option/PhabricatorSecurityConfigOptions.php b/src/applications/config/option/PhabricatorSecurityConfigOptions.php
--- a/src/applications/config/option/PhabricatorSecurityConfigOptions.php
+++ b/src/applications/config/option/PhabricatorSecurityConfigOptions.php
@@ -12,8 +12,7 @@
}
public function getOptions() {
- $support_href = PhabricatorEnv::getDoclink(
- 'article/feedback.html');
+ $support_href = PhabricatorEnv::getDoclink('Give Feedback! Get Support!');
return array(
$this->newOption('security.alternate-file-domain', 'string', null)
diff --git a/src/applications/differential/application/PhabricatorApplicationDifferential.php b/src/applications/differential/application/PhabricatorApplicationDifferential.php
--- a/src/applications/differential/application/PhabricatorApplicationDifferential.php
+++ b/src/applications/differential/application/PhabricatorApplicationDifferential.php
@@ -15,7 +15,7 @@
}
public function getHelpURI() {
- return PhabricatorEnv::getDoclink('article/Differential_User_Guide.html');
+ return PhabricatorEnv::getDoclink('Differential User Guide');
}
public function getFactObjectsForAnalysis() {
diff --git a/src/applications/differential/controller/DifferentialDiffCreateController.php b/src/applications/differential/controller/DifferentialDiffCreateController.php
--- a/src/applications/differential/controller/DifferentialDiffCreateController.php
+++ b/src/applications/differential/controller/DifferentialDiffCreateController.php
@@ -41,8 +41,7 @@
}
$form = new AphrontFormView();
- $arcanist_href = PhabricatorEnv::getDoclink(
- 'article/Arcanist_User_Guide.html');
+ $arcanist_href = PhabricatorEnv::getDoclink('Arcanist User Guide');
$arcanist_link = phutil_tag(
'a',
array(
diff --git a/src/applications/diffusion/application/PhabricatorApplicationDiffusion.php b/src/applications/diffusion/application/PhabricatorApplicationDiffusion.php
--- a/src/applications/diffusion/application/PhabricatorApplicationDiffusion.php
+++ b/src/applications/diffusion/application/PhabricatorApplicationDiffusion.php
@@ -15,7 +15,7 @@
}
public function getHelpURI() {
- return PhabricatorEnv::getDoclink('article/Diffusion_User_Guide.html');
+ return PhabricatorEnv::getDoclink('Diffusion User Guide');
}
public function getFactObjectsForAnalysis() {
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditEncodingController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditEncodingController.php
--- a/src/applications/diffusion/controller/DiffusionRepositoryEditEncodingController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryEditEncodingController.php
@@ -107,7 +107,7 @@
EOT
,
PhabricatorEnv::getDoclink(
- 'article/User_Guide_UTF-8_and_Character_Encoding.html'));
+ 'User Guide: UTF-8 and Character Encoding'));
}
}
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditHostingController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditHostingController.php
--- a/src/applications/diffusion/controller/DiffusionRepositoryEditHostingController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryEditHostingController.php
@@ -91,7 +91,7 @@
->setValue($v_hosting);
$doc_href = PhabricatorEnv::getDoclink(
- 'article/Diffusion_User_Guide_Repository_Hosting.html');
+ 'Diffusion User Guide: Repository Hosting');
$form = id(new AphrontFormView())
->setUser($user)
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
--- a/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
@@ -769,8 +769,8 @@
}
}
- $doc_href = PhabricatorEnv::getDocLink(
- 'article/Managing_Daemons_with_phd.html');
+ $doc_href = PhabricatorEnv::getDocLink('Managing Daemons with phd');
+
$daemon_instructions = pht(
'Use %s to start daemons. See %s.',
phutil_tag('tt', array(), 'bin/phd start'),
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryNewController.php b/src/applications/diffusion/controller/DiffusionRepositoryNewController.php
--- a/src/applications/diffusion/controller/DiffusionRepositoryNewController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryNewController.php
@@ -27,7 +27,7 @@
}
$doc_href = PhabricatorEnv::getDoclink(
- 'article/Diffusion_User_Guide_Repository_Hosting.html');
+ 'Diffusion User Guide: Repository Hosting');
$doc_link = phutil_tag(
'a',
diff --git a/src/applications/files/controller/PhabricatorFileUploadController.php b/src/applications/files/controller/PhabricatorFileUploadController.php
--- a/src/applications/files/controller/PhabricatorFileUploadController.php
+++ b/src/applications/files/controller/PhabricatorFileUploadController.php
@@ -94,7 +94,7 @@
}
$doc_href = PhabricatorEnv::getDocLink(
- 'article/Configuring_File_Upload_Limits.html');
+ 'Configuring File Upload Limits');
$doc_link = phutil_tag(
'a',
array(
diff --git a/src/applications/herald/application/PhabricatorApplicationHerald.php b/src/applications/herald/application/PhabricatorApplicationHerald.php
--- a/src/applications/herald/application/PhabricatorApplicationHerald.php
+++ b/src/applications/herald/application/PhabricatorApplicationHerald.php
@@ -19,7 +19,7 @@
}
public function getHelpURI() {
- return PhabricatorEnv::getDoclink('article/Herald_User_Guide.html');
+ return PhabricatorEnv::getDoclink('Herald User Guide');
}
public function getFlavorText() {
diff --git a/src/applications/home/controller/PhabricatorHomeMainController.php b/src/applications/home/controller/PhabricatorHomeMainController.php
--- a/src/applications/home/controller/PhabricatorHomeMainController.php
+++ b/src/applications/home/controller/PhabricatorHomeMainController.php
@@ -324,7 +324,7 @@
require_celerity_resource('phabricator-jump-nav');
- $doc_href = PhabricatorEnv::getDocLink('article/Jump_Nav_User_Guide.html');
+ $doc_href = PhabricatorEnv::getDocLink('Jump Nav User Guide');
$doc_link = phutil_tag(
'a',
array(
diff --git a/src/applications/oauthserver/controller/clientauthorization/PhabricatorOAuthClientAuthorizationListController.php b/src/applications/oauthserver/controller/clientauthorization/PhabricatorOAuthClientAuthorizationListController.php
--- a/src/applications/oauthserver/controller/clientauthorization/PhabricatorOAuthClientAuthorizationListController.php
+++ b/src/applications/oauthserver/controller/clientauthorization/PhabricatorOAuthClientAuthorizationListController.php
@@ -47,7 +47,7 @@
$updated = phabricator_datetime($authorization->getDateModified(),
$current_user);
$scope_doc_href = PhabricatorEnv::getDoclink(
- 'article/Using_the_Phabricator_OAuth_Server.html#scopes');
+ 'Using the Phabricator OAuth Server');
$row = array(
phutil_tag(
'a',
diff --git a/src/applications/owners/application/PhabricatorApplicationOwners.php b/src/applications/owners/application/PhabricatorApplicationOwners.php
--- a/src/applications/owners/application/PhabricatorApplicationOwners.php
+++ b/src/applications/owners/application/PhabricatorApplicationOwners.php
@@ -19,7 +19,7 @@
}
public function getHelpURI() {
- return PhabricatorEnv::getDoclink('article/Owners_Tool_User_Guide.html');
+ return PhabricatorEnv::getDoclink('Owners Tool User Guide');
}
public function getFlavorText() {
diff --git a/src/applications/phame/application/PhabricatorApplicationPhame.php b/src/applications/phame/application/PhabricatorApplicationPhame.php
--- a/src/applications/phame/application/PhabricatorApplicationPhame.php
+++ b/src/applications/phame/application/PhabricatorApplicationPhame.php
@@ -19,7 +19,7 @@
}
public function getHelpURI() {
- return PhabricatorEnv::getDoclink('article/Phame_User_Guide.html');
+ return PhabricatorEnv::getDoclink('Phame User Guide');
}
public function getApplicationGroup() {
diff --git a/src/applications/pholio/view/PholioInlineCommentEditView.php b/src/applications/pholio/view/PholioInlineCommentEditView.php
--- a/src/applications/pholio/view/PholioInlineCommentEditView.php
+++ b/src/applications/pholio/view/PholioInlineCommentEditView.php
@@ -96,8 +96,7 @@
$formatting = phutil_tag(
'a',
array(
- 'href' => PhabricatorEnv::getDoclink(
- 'article/Remarkup_Reference.html'),
+ 'href' => PhabricatorEnv::getDoclink('Remarkup Reference'),
'tabindex' => '-1',
'target' => '_blank',
),
diff --git a/src/applications/pholio/view/PholioInlineCommentSaveView.php b/src/applications/pholio/view/PholioInlineCommentSaveView.php
--- a/src/applications/pholio/view/PholioInlineCommentSaveView.php
+++ b/src/applications/pholio/view/PholioInlineCommentSaveView.php
@@ -84,8 +84,7 @@
$formatting = phutil_tag(
'a',
array(
- 'href' => PhabricatorEnv::getDoclink(
- 'article/Remarkup_Reference.html'),
+ 'href' => PhabricatorEnv::getDoclink('Remarkup Reference'),
'tabindex' => '-1',
'target' => '_blank',
),
diff --git a/src/applications/phriction/application/PhabricatorApplicationPhriction.php b/src/applications/phriction/application/PhabricatorApplicationPhriction.php
--- a/src/applications/phriction/application/PhabricatorApplicationPhriction.php
+++ b/src/applications/phriction/application/PhabricatorApplicationPhriction.php
@@ -15,7 +15,7 @@
}
public function getHelpURI() {
- return PhabricatorEnv::getDoclink('article/Phriction_User_Guide.html');
+ return PhabricatorEnv::getDoclink('Phriction User Guide');
}
public function getTitleGlyph() {
diff --git a/src/applications/search/engine/PhabricatorJumpNavHandler.php b/src/applications/search/engine/PhabricatorJumpNavHandler.php
--- a/src/applications/search/engine/PhabricatorJumpNavHandler.php
+++ b/src/applications/search/engine/PhabricatorJumpNavHandler.php
@@ -4,7 +4,7 @@
public static function getJumpResponse(PhabricatorUser $viewer, $jump) {
$jump = trim($jump);
- $help_href = PhabricatorEnv::getDocLink('article/Jump_Nav_User_Guide.html');
+ $help_href = PhabricatorEnv::getDocLink('Jump Nav User Guide');
$patterns = array(
'/^help/i' => 'uri:'.$help_href,
diff --git a/src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php b/src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php
--- a/src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php
+++ b/src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php
@@ -86,7 +86,7 @@
'a',
array(
'href' => PhabricatorEnv::getDoclink(
- 'article/User_Guide_Configuring_an_External_Editor.html'),
+ 'User Guide: Configuring an External Editor'),
),
pht('User Guide: Configuring an External Editor'));
diff --git a/src/applications/slowvote/application/PhabricatorApplicationSlowvote.php b/src/applications/slowvote/application/PhabricatorApplicationSlowvote.php
--- a/src/applications/slowvote/application/PhabricatorApplicationSlowvote.php
+++ b/src/applications/slowvote/application/PhabricatorApplicationSlowvote.php
@@ -19,7 +19,7 @@
}
public function getHelpURI() {
- return PhabricatorEnv::getDoclink('article/Slowvote_User_Guide.html');
+ return PhabricatorEnv::getDoclink('Slowvote User Guide');
}
public function getFlavorText() {
diff --git a/src/infrastructure/env/PhabricatorEnv.php b/src/infrastructure/env/PhabricatorEnv.php
--- a/src/infrastructure/env/PhabricatorEnv.php
+++ b/src/infrastructure/env/PhabricatorEnv.php
@@ -336,8 +336,12 @@
*
* @task read
*/
- public static function getDoclink($resource) {
- return 'http://www.phabricator.com/docs/phabricator/'.$resource;
+ public static function getDoclink($resource, $type = 'article') {
+ $uri = new PhutilURI('https://secure.phabricator.com/diviner/find/');
+ $uri->setQueryParam('name', $resource);
+ $uri->setQueryParam('type', $type);
+ $uri->setQueryParam('jump', true);
+ return (string)$uri;
}
diff --git a/src/view/form/control/PhabricatorRemarkupControl.php b/src/view/form/control/PhabricatorRemarkupControl.php
--- a/src/view/form/control/PhabricatorRemarkupControl.php
+++ b/src/view/form/control/PhabricatorRemarkupControl.php
@@ -87,8 +87,7 @@
$actions['help'] = array(
'tip' => pht('Help'),
'align' => 'right',
- 'href' => PhabricatorEnv::getDoclink(
- 'article/Remarkup_Reference.html'),
+ 'href' => PhabricatorEnv::getDoclink('Remarkup Reference'),
);
$actions[] = array(

File Metadata

Mime Type
text/plain
Expires
Sun, Mar 23, 10:00 AM (2 d, 8 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7616950
Default Alt Text
D8553.id20301.diff (15 KB)

Event Timeline