Page MenuHomePhabricator
Files F15422471

D18414.diff
No OneTemporary
Actions

D18414.diff
View Options

diff --git a/src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php b/src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php
--- a/src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php
+++ b/src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php
@@ -151,9 +151,8 @@
private function filterShouldUpdate(array $phids) {
$statuses = array(
- ArcanistDifferentialRevisionStatus::NEEDS_REVISION,
- ArcanistDifferentialRevisionStatus::CHANGES_PLANNED,
- ArcanistDifferentialRevisionStatus::IN_PREPARATION,
+ DifferentialRevisionStatus::NEEDS_REVISION,
+ DifferentialRevisionStatus::CHANGES_PLANNED,
);
$statuses = array_fuse($statuses);
@@ -161,7 +160,7 @@
$results = array();
foreach ($objects as $key => $object) {
- if (empty($statuses[$object->getStatus()])) {
+ if (empty($statuses[$object->getModernRevisionStatus()])) {
continue;
}
@@ -190,10 +189,9 @@
private function filterWaitingOnAuthors(array $phids) {
$statuses = array(
- ArcanistDifferentialRevisionStatus::ACCEPTED,
- ArcanistDifferentialRevisionStatus::NEEDS_REVISION,
- ArcanistDifferentialRevisionStatus::CHANGES_PLANNED,
- ArcanistDifferentialRevisionStatus::IN_PREPARATION,
+ DifferentialRevisionStatus::ACCEPTED,
+ DifferentialRevisionStatus::NEEDS_REVISION,
+ DifferentialRevisionStatus::CHANGES_PLANNED,
);
$statuses = array_fuse($statuses);
@@ -201,7 +199,7 @@
$results = array();
foreach ($objects as $key => $object) {
- if (empty($statuses[$object->getStatus()])) {
+ if (empty($statuses[$object->getModernRevisionStatus()])) {
continue;
}
diff --git a/src/applications/differential/storage/DifferentialRevision.php b/src/applications/differential/storage/DifferentialRevision.php
--- a/src/applications/differential/storage/DifferentialRevision.php
+++ b/src/applications/differential/storage/DifferentialRevision.php
@@ -627,6 +627,10 @@
return $this->setStatus($legacy_status);
}
+ public function getModernRevisionStatus() {
+ return $this->getStatusObject()->getKey();
+ }
+
public function isClosed() {
return $this->getStatusObject()->isClosedStatus();
}

File Metadata

Mime Type
text/plain
Expires
Sun, Mar 23, 8:35 AM (1 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7718224
Default Alt Text
D18414.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility