Page MenuHomePhabricator

D17544.id.diff
No OneTemporary

D17544.id.diff

diff --git a/src/applications/differential/query/DifferentialRevisionSearchEngine.php b/src/applications/differential/query/DifferentialRevisionSearchEngine.php
--- a/src/applications/differential/query/DifferentialRevisionSearchEngine.php
+++ b/src/applications/differential/query/DifferentialRevisionSearchEngine.php
@@ -162,10 +162,13 @@
$groups = $bucket->newResultGroups($query, $revisions);
foreach ($groups as $group) {
- $views[] = id(clone $template)
- ->setHeader($group->getName())
- ->setNoDataString($group->getNoDataString())
- ->setRevisions($group->getObjects());
+ // Don't show groups in Dashboard Panels
+ if ($group->getObjects() || !$this->isPanelContext()) {
+ $views[] = id(clone $template)
+ ->setHeader($group->getName())
+ ->setNoDataString($group->getNoDataString())
+ ->setRevisions($group->getObjects());
+ }
}
} catch (Exception $ex) {
$this->addError($ex->getMessage());
@@ -176,6 +179,12 @@
->setHandles(array());
}
+ if (!$views) {
+ $views[] = id(new DifferentialRevisionListView())
+ ->setUser($viewer)
+ ->setNoDataString(pht('No revisions found.'));
+ }
+
$phids = array_mergev(mpull($views, 'getRequiredHandlePHIDs'));
if ($phids) {
$handles = id(new PhabricatorHandleQuery())

File Metadata

Mime Type
text/plain
Expires
Sun, Mar 23, 6:43 AM (1 d, 12 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7718023
Default Alt Text
D17544.id.diff (1 KB)

Event Timeline