Page MenuHomePhabricator

D19874.diff
No OneTemporary

D19874.diff

diff --git a/src/applications/releeph/conduit/ReleephGetBranchesConduitAPIMethod.php b/src/applications/releeph/conduit/ReleephGetBranchesConduitAPIMethod.php
--- a/src/applications/releeph/conduit/ReleephGetBranchesConduitAPIMethod.php
+++ b/src/applications/releeph/conduit/ReleephGetBranchesConduitAPIMethod.php
@@ -30,11 +30,9 @@
foreach ($projects as $project) {
$repository = $project->getRepository();
- $branches = $project->loadRelatives(
- id(new ReleephBranch()),
- 'releephProjectID',
- 'getID',
- 'isActive = 1');
+ $branches = id(new ReleephBranch())->loadAllWhere(
+ 'releephProjectID = %d AND isActive = 1',
+ $project->getID());
foreach ($branches as $branch) {
$full_branch_name = $branch->getName();
diff --git a/src/applications/releeph/field/specification/ReleephDiffSizeFieldSpecification.php b/src/applications/releeph/field/specification/ReleephDiffSizeFieldSpecification.php
--- a/src/applications/releeph/field/specification/ReleephDiffSizeFieldSpecification.php
+++ b/src/applications/releeph/field/specification/ReleephDiffSizeFieldSpecification.php
@@ -22,16 +22,17 @@
}
$diff_rev = $requested_object;
- $diffs = $diff_rev->loadRelatives(
- new DifferentialDiff(),
- 'revisionID',
- 'getID',
- 'creationMethod <> "commit"');
+ $diffs = id(new DifferentialDiff())->loadAllWhere(
+ 'revisionID = %d AND creationMethod != %s',
+ $diff_rev->getID(),
+ 'commit');
$all_changesets = array();
$most_recent_changesets = null;
foreach ($diffs as $diff) {
- $changesets = $diff->loadRelatives(new DifferentialChangeset(), 'diffID');
+ $changesets = id(new DifferentialChangeset())->loadAllWhere(
+ 'diffID = %d',
+ $diff->getID());
$all_changesets += $changesets;
$most_recent_changesets = $changesets;
}

File Metadata

Mime Type
text/plain
Expires
Sun, Mar 23, 1:38 AM (2 h, 29 m ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7717690
Default Alt Text
D19874.diff (1 KB)

Event Timeline