Page MenuHomePhabricator
Files F15421484

D17680.id42524.diff
No OneTemporary
Actions

D17680.id42524.diff
View Options

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -316,6 +316,7 @@
'ConpherenceTestCase' => 'applications/conpherence/__tests__/ConpherenceTestCase.php',
'ConpherenceThread' => 'applications/conpherence/storage/ConpherenceThread.php',
'ConpherenceThreadDatasource' => 'applications/conpherence/typeahead/ConpherenceThreadDatasource.php',
+ 'ConpherenceThreadDateMarkerTransaction' => 'applications/conpherence/xaction/ConpherenceThreadDateMarkerTransaction.php',
'ConpherenceThreadIndexEngineExtension' => 'applications/conpherence/engineextension/ConpherenceThreadIndexEngineExtension.php',
'ConpherenceThreadListView' => 'applications/conpherence/view/ConpherenceThreadListView.php',
'ConpherenceThreadMailReceiver' => 'applications/conpherence/mail/ConpherenceThreadMailReceiver.php',
@@ -5107,6 +5108,7 @@
'PhabricatorNgramsInterface',
),
'ConpherenceThreadDatasource' => 'PhabricatorTypeaheadDatasource',
+ 'ConpherenceThreadDateMarkerTransaction' => 'ConpherenceThreadTransactionType',
'ConpherenceThreadIndexEngineExtension' => 'PhabricatorIndexEngineExtension',
'ConpherenceThreadListView' => 'AphrontView',
'ConpherenceThreadMailReceiver' => 'PhabricatorObjectMailReceiver',
diff --git a/src/applications/conpherence/ConpherenceTransactionRenderer.php b/src/applications/conpherence/ConpherenceTransactionRenderer.php
--- a/src/applications/conpherence/ConpherenceTransactionRenderer.php
+++ b/src/applications/conpherence/ConpherenceTransactionRenderer.php
@@ -60,7 +60,8 @@
// between days. some setup required!
$previous_transaction = null;
$date_marker_transaction = id(new ConpherenceTransaction())
- ->setTransactionType(ConpherenceTransaction::TYPE_DATE_MARKER)
+ ->setTransactionType(
+ ConpherenceThreadDateMarkerTransaction::TRANSACTIONTYPE)
->makeEphemeral();
$date_marker_transaction_view = id(new ConpherenceTransactionView())
->setUser($user)
diff --git a/src/applications/conpherence/storage/ConpherenceTransaction.php b/src/applications/conpherence/storage/ConpherenceTransaction.php
--- a/src/applications/conpherence/storage/ConpherenceTransaction.php
+++ b/src/applications/conpherence/storage/ConpherenceTransaction.php
@@ -4,7 +4,6 @@
extends PhabricatorModularTransaction {
const TYPE_PARTICIPANTS = 'participants';
- const TYPE_DATE_MARKER = 'date-marker';
public function getApplicationName() {
return 'conpherence';
@@ -39,8 +38,6 @@
switch ($this->getTransactionType()) {
case self::TYPE_PARTICIPANTS:
return ($old === null);
- case self::TYPE_DATE_MARKER:
- return false;
}
return parent::shouldHide();
@@ -93,8 +90,6 @@
$phids[] = $this->getAuthorPHID();
switch ($this->getTransactionType()) {
- case self::TYPE_DATE_MARKER:
- break;
case self::TYPE_PARTICIPANTS:
$phids = array_merge($phids, $this->getOldValue());
$phids = array_merge($phids, $this->getNewValue());
diff --git a/src/applications/conpherence/view/ConpherenceTransactionView.php b/src/applications/conpherence/view/ConpherenceTransactionView.php
--- a/src/applications/conpherence/view/ConpherenceTransactionView.php
+++ b/src/applications/conpherence/view/ConpherenceTransactionView.php
@@ -67,7 +67,7 @@
$transaction = $this->getConpherenceTransaction();
switch ($transaction->getTransactionType()) {
- case ConpherenceTransaction::TYPE_DATE_MARKER:
+ case ConpherenceThreadDateMarkerTransaction::TRANSACTIONTYPE:
return javelin_tag(
'div',
array(
diff --git a/src/applications/conpherence/xaction/ConpherenceThreadDateMarkerTransaction.php b/src/applications/conpherence/xaction/ConpherenceThreadDateMarkerTransaction.php
new file mode 100644
--- /dev/null
+++ b/src/applications/conpherence/xaction/ConpherenceThreadDateMarkerTransaction.php
@@ -0,0 +1,8 @@
+<?php
+
+final class ConpherenceThreadDateMarkerTransaction
+ extends ConpherenceThreadTransactionType {
+
+ const TRANSACTIONTYPE = 'date-marker';
+
+}

File Metadata

Mime Type
text/plain
Expires
Sun, Mar 23, 12:12 AM (1 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7714628
Default Alt Text
D17680.id42524.diff (4 KB)

Event Timeline

Phabricator · Built by Phacility